echarts icon indicating copy to clipboard operation
echarts copied to clipboard

useDirtyRect = true and saving image shows "Save as Image" label

Open dirslashls opened this issue 3 years ago • 4 comments

Version

5.0.0

Link to Minimal Reproduction

No response

Steps to Reproduce

  1. Go to https://echarts.apache.org/examples/en/editor.html?c=line-step
  2. Turn on "Use Dirty Rect"
  3. Download the image.

Current Behavior

It contains the "Save as Image" label.

Expected Behavior

It should not contain the "Save as Image" label in the image.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response

dirslashls avatar Feb 17 '22 18:02 dirslashls

This issue is labeled with difficulty: easy. @dirslashls Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.

Please have a look at How to debug ECharts if you'd like to give a try. 🤓

echarts-bot[bot] avatar Feb 18 '22 06:02 echarts-bot[bot]

I am not 100% sure but I think excluded elements during rendering for image need to be explicitly cleared when setting useDirtyRect to true.

dirslashls avatar Feb 21 '22 06:02 dirslashls

@plainheart hi, I find the problem that caused the current issue in zrender, could you help me to review my pr?

linghaoSu avatar Feb 24 '22 13:02 linghaoSu

This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.

github-actions[bot] avatar Feb 24 '24 21:02 github-actions[bot]

This issue has been automatically closed because it did not have recent activity. If this remains to be a problem with the latest version of Apache ECharts, please open a new issue and link this to it. Thanks!

github-actions[bot] avatar Mar 03 '24 21:03 github-actions[bot]