dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Support socks5 proxy username and password

Open jdxia opened this issue 1 year ago • 7 comments

  1. Support socks5 proxy username and password
  2. support tcp fastopen

jdxia avatar Oct 13 '24 19:10 jdxia

use mvn spotless:apply to format the code first

wcy666103 avatar Oct 20 '24 07:10 wcy666103

Thanks, Already formatted @wcy666103

jdxia avatar Oct 20 '24 08:10 jdxia

@AlbumenJ Hello, can you help me merge this pr? 😊 All checks have passed

jdxia avatar Oct 25 '24 14:10 jdxia

Should we proceed with merging this PR? If not, I will go ahead and close it. @AlbumenJ

jdxia avatar Jan 15 '25 09:01 jdxia

@CrazyHZM PTAL

AlbumenJ avatar Jan 28 '25 14:01 AlbumenJ

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.85%. Comparing base (84d8cc2) to head (b516cd5).

Files with missing lines Patch % Lines
...e/dubbo/remoting/transport/netty4/NettyClient.java 28.57% 5 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #14769      +/-   ##
============================================
- Coverage     60.74%   58.85%   -1.89%     
+ Complexity    10913       12   -10901     
============================================
  Files          1886     1886              
  Lines         86145    86151       +6     
  Branches      12906    12906              
============================================
- Hits          52331    50708    -1623     
- Misses        28359    29905    +1546     
- Partials       5455     5538      +83     
Flag Coverage Δ
integration-tests ?
samples-tests ?
unit-tests 58.85% <28.57%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 08 '25 15:05 codecov-commenter

dubbo-samples-spring-boot-hystrix is affected by this pr, and TCP_FASTOPEN is the cause.

Failed to refer invoker for interface:interface org.apache.dubbo.spring.boot.api.HelloService, ... : Failed to start NettyClient /172.19.0.3 connect to the server /172.19.0.2:20880, cause: TCP_FASTOPEN, dubbo version: 3.3.4-SNAPSHOT, current host: 172.19.0.3, error code: 4-3. This may be caused by , go to https://dubbo.apache.org/faq/4/3 to find instructions. 

zrlw avatar Jun 24 '25 09:06 zrlw