dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Failover retry extension

Open finefuture opened this issue 1 year ago • 3 comments

What is the purpose of the change

Allow users to customize whether to retry.

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

finefuture avatar Jul 22 '24 04:07 finefuture

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.13%. Comparing base (3e53e32) to head (718e24c). Report is 131 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #14457      +/-   ##
==========================================
+ Coverage   70.11%   70.13%   +0.02%     
==========================================
  Files        1607     1609       +2     
  Lines       70192    70236      +44     
  Branches    10116    10127      +11     
==========================================
+ Hits        49213    49263      +50     
  Misses      16324    16324              
+ Partials     4655     4649       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 22 '24 05:07 codecov-commenter

I think we can provide a brand new cluster to support it using SPI.

Okay, A new comprehensive retry police cluster will be provided, see grpc retry policy.

finefuture avatar Jul 23 '24 03:07 finefuture