dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

fix async method call ClassCastException error when requesting go server

Open FoghostCn opened this issue 1 year ago • 3 comments

What is the purpose of the change

fix https://github.com/apache/dubbo/issues/13931

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

FoghostCn avatar Mar 17 '24 15:03 FoghostCn

The same thing is happened at https://github.com/apache/dubbo/blob/0553d70899253519bd6fab00fb647eababf1c911/dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/stub/StubInvocationUtil.java#L53-L62

maybe we should find a unified way to solve this problem

FoghostCn avatar Mar 17 '24 15:03 FoghostCn

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.45%. Comparing base (4c59877) to head (aa9214d). Report is 248 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13932      +/-   ##
==========================================
- Coverage   70.51%   70.45%   -0.06%     
==========================================
  Files        1607     1607              
  Lines       70071    70073       +2     
  Branches    10100    10101       +1     
==========================================
- Hits        49412    49372      -40     
- Misses      16044    16067      +23     
- Partials     4615     4634      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 18 '24 04:03 codecov-commenter