dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

The handling of jsr310 times (package names start with java.time) is open to customization with dubbo's own spi implementation, which provides a default implementation in spring that allows you to configure date formats

Open Aresxue opened this issue 2 years ago • 3 comments

What is the purpose of the change

Specify the jsr310 time format based on the configuration when generic invoke

Verifying this change

org.apache.dubbo.spring.boot.context.event.Jsr310ConverterApplicationListenerTest

Aresxue avatar Sep 18 '23 06:09 Aresxue

image

AlbumenJ avatar Sep 26 '23 12:09 AlbumenJ

image

Test cases failed.

AlbumenJ avatar Sep 29 '23 12:09 AlbumenJ

Codecov Report

:x: Patch coverage is 34.17722% with 52 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.47%. Comparing base (717053e) to head (f8ddc26).

Files with missing lines Patch % Lines
...text/event/Jsr310ConverterApplicationListener.java 29.16% 13 Missing and 4 partials :warning:
...vert/jsr310/AbstractTemporalAccessorConverter.java 15.78% 16 Missing :warning:
.../java/org/apache/dubbo/common/utils/PojoUtils.java 66.66% 2 Missing and 5 partials :warning:
...mmon/convert/jsr310/DefaultLocalDateConverter.java 20.00% 4 Missing :warning:
.../convert/jsr310/DefaultLocalDateTimeConverter.java 20.00% 4 Missing :warning:
...mmon/convert/jsr310/DefaultLocalTimeConverter.java 20.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##                3.2   #13067   +/-   ##
=========================================
  Coverage     41.47%   41.47%           
- Complexity    10541    10555   +14     
=========================================
  Files          1652     1657    +5     
  Lines         71461    71531   +70     
  Branches      10163    10169    +6     
=========================================
+ Hits          29635    29670   +35     
- Misses        37693    37724   +31     
- Partials       4133     4137    +4     
Flag Coverage Δ
integration-tests 38.55% <34.17%> (+0.02%) :arrow_up:
samples-tests 36.40% <30.37%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Sep 08 '25 11:09 codecov-commenter

you'd better create a new pr to dubbo 3.3, as for me, dubbo 3.2 has not been maintained for a while.

zrlw avatar Sep 09 '25 02:09 zrlw

pls remove all author infos to meet apache license requirements.

zrlw avatar Sep 09 '25 02:09 zrlw