dubbo-go icon indicating copy to clipboard operation
dubbo-go copied to clipboard

Imp: move aksk auth to codec layer

Open AnneYang720 opened this issue 3 years ago • 2 comments

What this PR does: This PR moves ak/sk based signature authentication to codec layer and is implemented on dubbo protocol.

This method can validate entire request body, thus avoid vulnerablity in deserialization.

Which issue(s) this PR is related to: #1906

You should pay attention to items below to ensure your pr passes our ci test We do not merge pr with ci tests failed

  • [ ] All ut passed (run 'go test ./...' in project root)
  • [ ] After go-fmt ed , run 'go fmt project' using goland.
  • [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • [ ] After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • [ ] Your new-created file needs to have apache license at the top, like other existed file does.
  • [ ] All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

AnneYang720 avatar Jul 30 '22 15:07 AnneYang720

@AnneYang720 pls attention that our main developing branch is 3.0. I have changed this pr's target branch.

AlexStocks avatar Aug 02 '22 11:08 AlexStocks

@AnneYang720 现在这个 pr 是什么状态,还需要继续推进吗?

AlexStocks avatar Oct 14 '22 13:10 AlexStocks