apache
Revert "Use canonical hostname instead of ip by default (#16386)"
This reverts commit 9459722ebf6565d7161edab671d91588ff2c6e1b.
The effect of PR https://github.com/apache/druid/pull/16386 is that by default, services would advertise themselves with localhost instead of their IP address and because of that, services in docker no longer can discover each other. I ran into this issue while verifying the docker image of 31 RC 1. We don't see this being an issue in IT because there, druid.host is already set to the container name.
Instead of reverting, what do you guys think about just adding ENV DRUID_SET_HOST_IP=1 into the Dockerfile? The reasoning here is that when running Druid on Kubernetes with ephemeral IP's certain features such as restoreTasksOnRestart break. Using canonical hostname is also helpful when looking at the Druid console since hostnames are easier to reason about than IP's
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
ENV DRUID_SET_HOST_IP=1 into the Dockerfile
This is a change in behavior no? Do rolling upgrades work if we do this ?
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.