druid icon indicating copy to clipboard operation
druid copied to clipboard

Web console: expose handoff API

Open vogievetsky opened this issue 1 year ago • 3 comments

Expose handoff API added in https://github.com/apache/druid/pull/16310

image image

vogievetsky avatar Jun 11 '24 22:06 vogievetsky

Where on the UI are the Task Group IDs found?

If this is the "Group ID" value from the Tasks tab, then would it make more sense to implement the "Early Handoff" option on the Tasks tab instead of the Supervisor tab?

I understand it is the Supervisor that needs the direct instruction and not the Task ... but from a user perspective it is the task that I am cycling, not the Supervisor.

Thanks. John

johnImply avatar Jun 12 '24 11:06 johnImply

Where on the UI are the Task Group IDs found?

If this is the "Group ID" value from the Tasks tab, then would it make more sense to implement the "Early Handoff" option on the Tasks tab instead of the Supervisor tab?

I understand it is the Supervisor that needs the direct instruction and not the Task ... but from a user perspective it is the task that I am cycling, not the Supervisor.

Thanks. John

the task's taskGroupId is under the streaming task -> ioConfig -> taskGroupId. i think it still makes sense to have it on the supervisor (since you can specify multiple tasks to handoff, and like you said the api is operating on the supervisor). it would be nice to have a more explicit group -> task_id mapping available somewhere in the superivsor though.

i have observed that the Statistics tab for the supervisor already shows tasks by ascending group id (1,2,3,4,5, etc) so maybe it could be there, or alternatively just in the status page

georgew5656 avatar Jun 12 '24 14:06 georgew5656

Verbiage ... do we need to make a distinction between "supervisor handoff" and "task group handoff"?

I thought a "supervisor handoff" involved cycling all tasks for the supervisor ... this is what we can do by "Open in Data Loader" and then Submit without making any changes to the supervisor spec.

If there is any ambiguity here it might be safer to always reference "task group(s)" as the thing being handed off. My understanding is that Supervisor is merely the orchestrator here.

johnImply avatar Jun 12 '24 17:06 johnImply

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 12 '24 00:08 github-actions[bot]