druid icon indicating copy to clipboard operation
druid copied to clipboard

Hadoop based batch ingestion support range partition

Open hqx871 opened this issue 3 years ago • 3 comments

Description

This pr implements range partitioning for hadoop-based ingestion. For detail about multi dimension range partition can be seen https://github.com/apache/druid/pull/11848. This pr also add a sample parameter to fast DeterminePartitionsJob.


Key changed/added classes in this PR
  • DeterminePartitionsJob
  • HadoopTuningConfig

This PR has:

  • [ ] been self-reviewed.
    • [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • [ ] added documentation for new or modified features or behaviors.
  • [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • [ ] added or updated version, license, or notice information in licenses.yaml
  • [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • [ ] added integration tests.
  • [ ] been tested in a test Druid cluster.

hqx871 avatar Apr 17 '22 12:04 hqx871

Hey @hqx871 forced-push on a PR is not recommended. See the contributing.md

Avoid rebasing and force pushes after submitting a pull request, since these make it difficult for reviewers to see what you've changed in response to their reviews. The Druid committer that merges your change will rebase and squash it into a single commit before committing it to master.

FrankChen021 avatar Apr 20 '22 11:04 FrankChen021

Hey @hqx871 forced-push on a PR is not recommended. See the contributing.md

Avoid rebasing and force pushes after submitting a pull request, since these make it difficult for reviewers to see what you've changed in response to their reviews. The Druid committer that merges your change will rebase and squash it into a single commit before committing it to master.

Get. I will read the contributing.md

hqx871 avatar Apr 20 '22 11:04 hqx871

This feature will help us also. Any plans to merge?

rshanmugam1 avatar Jul 20 '22 20:07 rshanmugam1

This feature will help us also. Any plans to merge?

+1

@hqx871 @FrankChen021 do you happen to know whether it will be included into an upcoming release?

aharbunou-branch avatar Oct 24 '22 18:10 aharbunou-branch