doris icon indicating copy to clipboard operation
doris copied to clipboard

[BugFix](Cloud) Fix be cannot get meta service endpoint with meta service list

Open GoGoWen opened this issue 1 year ago • 11 comments

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

issue found in version: doris-3.0.3-rc03-5890d031c8b

when add BE node in cloud env just like local env with the meta_service_endpoint=ip1:5000,ip2:5000,ip3:5000, the BE may parse the endpoint to host=ip1:5000,ip2:5000,ip3 and port=5000. which cause be can not connect to the meta service.

Release note

None

Check List (For Author)

  • Test

    • [ ] Regression test
    • [ ] Unit Test
    • [ ] Manual test (add detailed scripts or steps below)
    • [ ] No need to test or manual test. Explain why:
      • [ ] This is a refactor/code format and no logic has been changed.
      • [ ] Previous test can cover this change.
      • [ ] No code files have been changed.
      • [ ] Other reason
  • Behavior changed:

    • [ ] No.
    • [ ] Yes.
  • Does this need documentation?

    • [ ] No.
    • [ ] Yes.

Check List (For Reviewer who merge this PR)

  • [ ] Confirm the release note
  • [ ] Confirm test cases
  • [ ] Confirm document
  • [ ] Add branch pick label

GoGoWen avatar Dec 18 '24 10:12 GoGoWen

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

hello-stephen avatar Dec 18 '24 10:12 hello-stephen

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In gensrc/script/gen_build_version.sh line 38:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.


In gensrc/script/gen_build_version.sh line 228:
if [[ ${build_version_hotfix} > 0 ]]; then
                              ^-- SC2071 (error): > is for string comparisons. Use -gt instead.

For more information:
  https://www.shellcheck.net/wiki/SC2071 -- > is for string comparisons. Use ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

github-actions[bot] avatar Dec 18 '24 10:12 github-actions[bot]

run buildall

GoGoWen avatar Dec 18 '24 10:12 GoGoWen

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 18 '24 10:12 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 38.88% (10133/26065) Line Coverage: 29.79% (85179/285911) Region Coverage: 28.83% (43681/151497) Branch Coverage: 25.37% (22192/87462) Coverage Report: http://coverage.selectdb-in.cc/coverage/1a57bf2f8f633e16ac5fb2fa8c2e0e606b7dbaf7_1a57bf2f8f633e16ac5fb2fa8c2e0e606b7dbaf7/report/index.html

doris-robot avatar Dec 18 '24 11:12 doris-robot

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 19 '24 05:12 github-actions[bot]

run buildall

GoGoWen avatar Dec 19 '24 06:12 GoGoWen

TeamCity be ut coverage result: Function Coverage: 38.87% (10132/26066) Line Coverage: 29.79% (85180/285967) Region Coverage: 28.83% (43680/151526) Branch Coverage: 25.37% (22194/87484) Coverage Report: http://coverage.selectdb-in.cc/coverage/c3e68ce3c26812ac1220394c814924d4f2977d4b_c3e68ce3c26812ac1220394c814924d4f2977d4b/report/index.html

doris-robot avatar Dec 19 '24 06:12 doris-robot

run p0

GoGoWen avatar Dec 19 '24 07:12 GoGoWen

run cloud_p0

GoGoWen avatar Dec 20 '24 06:12 GoGoWen

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

github-actions[bot] avatar Jun 19 '25 00:06 github-actions[bot]