doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](multi-catalog) Revert #36575 and check nullptr of data column

Open AshinGau opened this issue 1 year ago • 4 comments

Proposed changes

Revert #36575, because VScanner::get_block will check DCHECK(block->rows() == 0), so block should be cleared when eof = true.

AshinGau avatar Jul 01 '24 10:07 AshinGau

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Jul 01 '24 10:07 doris-robot

run buildall

AshinGau avatar Jul 01 '24 10:07 AshinGau

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 01 '24 10:07 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.34% (9151/25185) Line Coverage: 27.88% (74680/267891) Region Coverage: 26.79% (38513/143782) Branch Coverage: 23.48% (19520/83136) Coverage Report: http://coverage.selectdb-in.cc/coverage/8aafc51275fb21c6dcd1adfe2403df7402e76e45_8aafc51275fb21c6dcd1adfe2403df7402e76e45/report/index.html

doris-robot avatar Jul 01 '24 10:07 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Jul 01 '24 14:07 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Jul 01 '24 14:07 github-actions[bot]