doris icon indicating copy to clipboard operation
doris copied to clipboard

[BugFix](StoragePolicy) fix modify partition's storage policy with different resource issue succeed with execption

Open Johnnyssc opened this issue 1 year ago • 8 comments

Proposed changes

Issue Number: close #34229

when we try to modify a partition's storage policy which have different resource with the previous one, we get error message "currently do not support change origin storage policy to another one with different resource", but the modification same also succeed!

expect: the modification fail with "currently do not support change origin storage policy to another one with different resource".

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Johnnyssc avatar May 30 '24 10:05 Johnnyssc

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 30 '24 10:05 doris-robot

run buildall

Johnnyssc avatar May 30 '24 10:05 Johnnyssc

run FE UT

Johnnyssc avatar May 30 '24 10:05 Johnnyssc

run buildall

Johnnyssc avatar May 31 '24 02:05 Johnnyssc

TPC-H: Total hot run time: 42053 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 519abb2ac4b2e9610fbec05772e014b7be0264d2, data reload: false

------ Round 1 ----------------------------------
q1	17674	4414	4280	4280
q2	2024	199	198	198
q3	10502	1299	1281	1281
q4	10202	919	854	854
q5	7453	2672	2690	2672
q6	220	136	132	132
q7	964	643	616	616
q8	9220	2156	2107	2107
q9	9450	6730	6723	6723
q10	9271	3862	3849	3849
q11	445	245	242	242
q12	415	230	239	230
q13	17206	3180	3237	3180
q14	271	225	249	225
q15	510	462	485	462
q16	485	384	369	369
q17	966	704	764	704
q18	8499	7938	7733	7733
q19	3819	1637	1599	1599
q20	650	314	322	314
q21	5092	3953	3966	3953
q22	380	330	339	330
Total cold run time: 115718 ms
Total hot run time: 42053 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4580	4433	4407	4407
q2	385	279	284	279
q3	3144	2989	2751	2751
q4	1844	1604	1671	1604
q5	5480	5527	5529	5527
q6	208	122	121	121
q7	2187	1867	1823	1823
q8	3270	3350	3349	3349
q9	8706	8701	8684	8684
q10	3931	3798	3892	3798
q11	584	506	496	496
q12	801	613	610	610
q13	16843	3187	3205	3187
q14	293	265	279	265
q15	540	477	466	466
q16	489	413	413	413
q17	1775	1484	1469	1469
q18	7610	7749	7531	7531
q19	1731	1567	1605	1567
q20	2003	1784	1797	1784
q21	5002	4698	4553	4553
q22	610	491	517	491
Total cold run time: 72016 ms
Total hot run time: 55175 ms

doris-robot avatar May 31 '24 03:05 doris-robot

TPC-DS: Total hot run time: 169620 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 519abb2ac4b2e9610fbec05772e014b7be0264d2, data reload: false

query1	916	396	375	375
query2	6427	2483	2418	2418
query3	6645	203	208	203
query4	19986	17502	17288	17288
query5	4128	423	424	423
query6	252	159	155	155
query7	4583	295	294	294
query8	325	298	292	292
query9	8373	2372	2357	2357
query10	441	271	258	258
query11	10676	10301	10215	10215
query12	141	91	89	89
query13	1659	370	393	370
query14	8434	7853	6841	6841
query15	241	190	194	190
query16	7755	277	273	273
query17	1688	558	525	525
query18	1990	269	267	267
query19	202	154	154	154
query20	92	84	83	83
query21	206	126	129	126
query22	4375	4264	3996	3996
query23	34419	33096	33037	33037
query24	10258	2868	2775	2775
query25	570	357	362	357
query26	708	171	156	156
query27	2156	321	338	321
query28	5846	2046	2073	2046
query29	903	617	596	596
query30	245	150	149	149
query31	985	756	760	756
query32	85	54	52	52
query33	645	267	264	264
query34	887	480	477	477
query35	718	620	626	620
query36	1062	916	905	905
query37	106	65	66	65
query38	2932	2753	2769	2753
query39	894	794	776	776
query40	219	126	124	124
query41	55	51	51	51
query42	109	99	95	95
query43	583	571	566	566
query44	1065	737	744	737
query45	186	173	166	166
query46	1069	714	715	714
query47	1868	1774	1780	1774
query48	377	301	294	294
query49	836	379	408	379
query50	771	380	389	380
query51	6746	6649	6701	6649
query52	105	90	98	90
query53	352	280	284	280
query54	854	430	430	430
query55	75	72	75	72
query56	272	235	241	235
query57	1129	1040	1043	1040
query58	234	211	203	203
query59	3481	3289	3199	3199
query60	291	280	251	251
query61	87	89	87	87
query62	588	451	453	451
query63	309	293	291	291
query64	8483	2243	1743	1743
query65	3147	3072	3111	3072
query66	784	317	326	317
query67	15430	14836	14799	14799
query68	4525	551	530	530
query69	458	267	272	267
query70	1151	1086	1126	1086
query71	355	275	268	268
query72	7385	2719	2530	2530
query73	709	321	323	321
query74	6138	5691	5703	5691
query75	3282	2660	2651	2651
query76	2358	971	951	951
query77	464	264	269	264
query78	10243	9772	9720	9720
query79	2341	512	515	512
query80	994	497	431	431
query81	511	223	218	218
query82	775	91	93	91
query83	250	167	186	167
query84	247	89	86	86
query85	1457	272	263	263
query86	462	314	320	314
query87	3297	3118	3131	3118
query88	4313	2345	2349	2345
query89	481	397	383	383
query90	2067	192	190	190
query91	126	101	107	101
query92	60	48	54	48
query93	2316	489	504	489
query94	1264	239	180	180
query95	401	303	312	303
query96	583	267	264	264
query97	3221	3014	3002	3002
query98	255	220	224	220
query99	1189	830	838	830
Total cold run time: 266137 ms
Total hot run time: 169620 ms

doris-robot avatar May 31 '24 03:05 doris-robot

ClickBench: Total hot run time: 29.9 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 519abb2ac4b2e9610fbec05772e014b7be0264d2, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.49	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.53	0.48	0.49
query10	0.54	0.57	0.54
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.76	0.79	0.77
query15	0.83	0.81	0.81
query16	0.36	0.37	0.37
query17	0.97	0.95	1.03
query18	0.21	0.24	0.27
query19	1.76	1.81	1.65
query20	0.01	0.02	0.01
query21	15.63	0.68	0.67
query22	4.47	8.14	1.31
query23	18.25	1.39	1.24
query24	1.66	0.26	0.24
query25	0.14	0.08	0.08
query26	0.27	0.17	0.16
query27	0.08	0.08	0.08
query28	13.36	1.02	0.99
query29	13.40	3.30	3.26
query30	0.24	0.06	0.05
query31	2.86	0.38	0.38
query32	3.27	0.48	0.47
query33	2.88	2.88	2.96
query34	16.96	4.46	4.43
query35	4.49	4.51	4.59
query36	0.69	0.48	0.46
query37	0.17	0.15	0.16
query38	0.15	0.16	0.15
query39	0.05	0.03	0.03
query40	0.16	0.14	0.15
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.03	0.03	0.04
Total cold run time: 109.95 s
Total hot run time: 29.9 s

doris-robot avatar May 31 '24 03:05 doris-robot

run FE UT

Johnnyssc avatar May 31 '24 05:05 Johnnyssc

run buildall

Johnnyssc avatar May 31 '24 09:05 Johnnyssc