doris icon indicating copy to clipboard operation
doris copied to clipboard

[improvement](chore) remove unused code of RuntimeState

Open jacktengg opened this issue 1 year ago • 11 comments

Proposed changes

Issue Number: close #xxx

jacktengg avatar May 30 '24 09:05 jacktengg

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 30 '24 09:05 doris-robot

run buildall

jacktengg avatar May 30 '24 09:05 jacktengg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 30 '24 09:05 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 30 '24 09:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 30 '24 09:05 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.27% (9229/25448) Line Coverage: 27.61% (75668/274016) Region Coverage: 26.83% (39157/145957) Branch Coverage: 23.59% (19881/84280) Coverage Report: http://coverage.selectdb-in.cc/coverage/fe7760ff13645ddb273676fa33dff9fdc048792f_fe7760ff13645ddb273676fa33dff9fdc048792f/report/index.html

doris-robot avatar May 30 '24 09:05 doris-robot

TPC-H: Total hot run time: 41533 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe7760ff13645ddb273676fa33dff9fdc048792f, data reload: false

------ Round 1 ----------------------------------
q1	17609	5049	4340	4340
q2	2027	198	200	198
q3	10438	1207	1259	1207
q4	10222	841	783	783
q5	7493	2749	2724	2724
q6	224	134	136	134
q7	992	622	626	622
q8	9216	2143	2118	2118
q9	9524	6734	6750	6734
q10	9406	3929	3876	3876
q11	448	268	260	260
q12	516	223	229	223
q13	17495	3199	3291	3199
q14	254	210	228	210
q15	525	472	477	472
q16	508	402	396	396
q17	1011	665	712	665
q18	8367	7953	7860	7860
q19	7383	1652	1581	1581
q20	640	330	318	318
q21	5239	4148	3282	3282
q22	393	337	331	331
Total cold run time: 119930 ms
Total hot run time: 41533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4507	4470	4417	4417
q2	375	264	277	264
q3	3153	2888	2942	2888
q4	2002	1595	1616	1595
q5	5388	5545	5504	5504
q6	215	128	127	127
q7	2228	1837	1803	1803
q8	3251	3440	3469	3440
q9	8619	8668	8694	8668
q10	4069	3770	3722	3722
q11	579	507	511	507
q12	819	642	618	618
q13	16896	3201	3153	3153
q14	293	285	292	285
q15	538	492	514	492
q16	519	444	435	435
q17	1838	1550	1542	1542
q18	7801	7567	7432	7432
q19	1674	1615	1550	1550
q20	2064	1788	1783	1783
q21	14220	4783	4757	4757
q22	609	538	551	538
Total cold run time: 81657 ms
Total hot run time: 55520 ms

doris-robot avatar May 30 '24 10:05 doris-robot

TPC-DS: Total hot run time: 169130 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe7760ff13645ddb273676fa33dff9fdc048792f, data reload: false

query1	919	384	373	373
query2	6465	2324	2408	2324
query3	6652	217	212	212
query4	19537	17366	17411	17366
query5	4134	425	429	425
query6	245	170	153	153
query7	4594	299	288	288
query8	305	278	270	270
query9	8429	2421	2413	2413
query10	451	283	267	267
query11	10633	10237	10017	10017
query12	135	87	87	87
query13	1635	359	364	359
query14	10105	7468	6940	6940
query15	231	184	187	184
query16	7342	269	256	256
query17	1319	523	531	523
query18	1925	265	271	265
query19	197	154	158	154
query20	89	84	82	82
query21	204	135	144	135
query22	4230	3980	3896	3896
query23	33547	32991	33061	32991
query24	7038	2786	2898	2786
query25	542	360	372	360
query26	711	152	157	152
query27	1971	309	320	309
query28	3850	2086	2094	2086
query29	866	599	583	583
query30	218	152	151	151
query31	944	761	731	731
query32	93	56	55	55
query33	498	272	267	267
query34	846	469	477	469
query35	692	636	603	603
query36	1076	955	912	912
query37	103	70	70	70
query38	2909	2799	2779	2779
query39	875	791	793	791
query40	201	127	124	124
query41	51	50	52	50
query42	103	97	95	95
query43	561	535	543	535
query44	1123	726	754	726
query45	200	163	168	163
query46	1060	720	693	693
query47	1870	1790	1785	1785
query48	373	297	288	288
query49	758	384	402	384
query50	771	389	381	381
query51	6868	6775	6616	6616
query52	109	88	90	88
query53	355	284	300	284
query54	541	469	433	433
query55	75	72	73	72
query56	271	245	270	245
query57	1098	1062	1047	1047
query58	232	215	203	203
query59	3241	3240	3083	3083
query60	272	253	250	250
query61	87	84	86	84
query62	556	447	461	447
query63	309	287	284	284
query64	8507	2295	1745	1745
query65	3170	3115	3110	3110
query66	825	326	336	326
query67	15161	14766	14985	14766
query68	4603	541	552	541
query69	441	259	263	259
query70	1147	1137	1119	1119
query71	394	270	272	270
query72	7640	2692	2537	2537
query73	718	324	323	323
query74	6073	5684	5625	5625
query75	3337	2656	2616	2616
query76	2305	955	945	945
query77	447	268	274	268
query78	10236	9802	9634	9634
query79	2671	521	523	521
query80	989	444	432	432
query81	482	222	220	220
query82	897	89	92	89
query83	234	175	167	167
query84	248	86	86	86
query85	1022	264	273	264
query86	461	299	293	293
query87	3302	3141	3146	3141
query88	4329	2331	2344	2331
query89	467	385	378	378
query90	2002	189	183	183
query91	131	108	108	108
query92	69	50	51	50
query93	1877	525	509	509
query94	1123	198	256	198
query95	396	305	305	305
query96	587	273	261	261
query97	3204	3003	3014	3003
query98	240	227	214	214
query99	1199	849	854	849
Total cold run time: 258574 ms
Total hot run time: 169130 ms

doris-robot avatar May 30 '24 10:05 doris-robot

ClickBench: Total hot run time: 30.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe7760ff13645ddb273676fa33dff9fdc048792f, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.51	0.49	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.54	0.55	0.52
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.76	0.78	0.78
query15	0.83	0.81	0.81
query16	0.35	0.37	0.35
query17	0.97	0.97	0.96
query18	0.22	0.24	0.25
query19	1.76	1.66	1.70
query20	0.01	0.00	0.01
query21	15.51	0.67	0.65
query22	4.20	7.34	2.15
query23	18.27	1.28	1.25
query24	1.39	0.39	0.22
query25	0.14	0.08	0.09
query26	0.26	0.17	0.17
query27	0.08	0.08	0.08
query28	13.34	1.01	1.00
query29	13.30	3.36	3.31
query30	0.25	0.05	0.07
query31	2.91	0.38	0.37
query32	3.26	0.47	0.46
query33	2.94	2.85	2.87
query34	17.06	4.41	4.46
query35	4.50	4.51	4.55
query36	0.72	0.49	0.47
query37	0.18	0.16	0.15
query38	0.16	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.14	0.17
query41	0.10	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.5 s
Total hot run time: 30.7 s

doris-robot avatar May 30 '24 10:05 doris-robot

run p1

jacktengg avatar May 31 '24 01:05 jacktengg

run external

jacktengg avatar May 31 '24 01:05 jacktengg

run buildall

yiguolei avatar May 31 '24 16:05 yiguolei

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 31 '24 16:05 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.26% (9232/25458) Line Coverage: 27.63% (75721/274076) Region Coverage: 26.84% (39198/146042) Branch Coverage: 23.59% (19893/84318) Coverage Report: http://coverage.selectdb-in.cc/coverage/05dfa002cfc5f9a8084a7aa39170f4c58029679d_05dfa002cfc5f9a8084a7aa39170f4c58029679d/report/index.html

doris-robot avatar May 31 '24 17:05 doris-robot

run performance

zhiqiang-hhhh avatar Jun 14 '24 09:06 zhiqiang-hhhh

TPC-H: Total hot run time: 40265 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 05dfa002cfc5f9a8084a7aa39170f4c58029679d, data reload: false

------ Round 1 ----------------------------------
q1	17623	4473	4305	4305
q2	2034	195	198	195
q3	10438	1152	1141	1141
q4	10186	824	794	794
q5	7514	2691	2697	2691
q6	221	141	140	140
q7	980	640	613	613
q8	9233	2099	2085	2085
q9	9164	6599	6545	6545
q10	8983	3731	3709	3709
q11	476	244	241	241
q12	508	241	242	241
q13	17765	2957	2981	2957
q14	265	216	227	216
q15	519	470	458	458
q16	539	376	378	376
q17	972	692	748	692
q18	8134	7589	7394	7394
q19	7849	1495	1487	1487
q20	659	321	332	321
q21	5073	3336	3974	3336
q22	401	328	338	328
Total cold run time: 119536 ms
Total hot run time: 40265 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4393	4448	4254	4254
q2	373	271	259	259
q3	3229	2905	2880	2880
q4	2043	1765	1776	1765
q5	5478	5523	5597	5523
q6	233	136	140	136
q7	2239	1833	1875	1833
q8	3313	3452	3392	3392
q9	8642	8923	8770	8770
q10	4041	3758	3895	3758
q11	582	523	505	505
q12	862	673	625	625
q13	16651	3143	3187	3143
q14	311	276	270	270
q15	527	482	489	482
q16	490	435	455	435
q17	1794	1528	1524	1524
q18	8268	7975	8045	7975
q19	3097	1664	1605	1605
q20	2138	1850	1861	1850
q21	5258	4693	4985	4693
q22	617	529	539	529
Total cold run time: 74579 ms
Total hot run time: 56206 ms

doris-robot avatar Jun 14 '24 10:06 doris-robot

TPC-DS: Total hot run time: 173083 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 05dfa002cfc5f9a8084a7aa39170f4c58029679d, data reload: false

query1	926	375	378	375
query2	6407	2514	2289	2289
query3	6653	206	209	206
query4	18716	17176	17251	17176
query5	3534	468	447	447
query6	232	168	158	158
query7	4580	305	290	290
query8	332	294	281	281
query9	8710	2425	2372	2372
query10	547	287	273	273
query11	10666	10062	10059	10059
query12	115	88	82	82
query13	1642	374	368	368
query14	10051	6808	6890	6808
query15	236	196	194	194
query16	7716	260	260	260
query17	1756	523	508	508
query18	1851	274	310	274
query19	187	154	153	153
query20	88	82	82	82
query21	200	126	122	122
query22	4540	4250	4080	4080
query23	33776	33646	33644	33644
query24	11129	2982	2895	2895
query25	649	401	401	401
query26	746	170	158	158
query27	2351	355	339	339
query28	6170	2115	2132	2115
query29	878	642	624	624
query30	251	154	156	154
query31	974	789	733	733
query32	98	52	54	52
query33	766	289	306	289
query34	1066	509	478	478
query35	757	617	686	617
query36	1111	977	936	936
query37	145	72	81	72
query38	2993	2834	2852	2834
query39	903	854	825	825
query40	213	128	134	128
query41	56	53	54	53
query42	119	101	106	101
query43	589	564	553	553
query44	1247	728	731	728
query45	190	161	158	158
query46	1071	728	694	694
query47	1866	1807	1745	1745
query48	374	305	300	300
query49	850	404	413	404
query50	748	385	394	385
query51	6809	6665	6721	6665
query52	99	94	92	92
query53	353	297	281	281
query54	899	438	428	428
query55	72	74	74	74
query56	279	256	262	256
query57	1094	1031	1066	1031
query58	244	247	250	247
query59	3338	2992	2988	2988
query60	302	288	285	285
query61	111	131	90	90
query62	620	440	454	440
query63	317	290	301	290
query64	8813	2245	1720	1720
query65	3180	3065	3105	3065
query66	830	327	326	326
query67	15470	15055	14975	14975
query68	4517	523	543	523
query69	584	450	386	386
query70	1181	1065	1089	1065
query71	438	269	274	269
query72	7331	5350	5329	5329
query73	753	322	320	320
query74	5918	5530	5496	5496
query75	3423	2661	2660	2660
query76	2386	951	888	888
query77	569	296	297	296
query78	10191	10044	9718	9718
query79	2250	515	521	515
query80	1981	466	451	451
query81	572	223	218	218
query82	794	106	100	100
query83	311	170	166	166
query84	273	87	87	87
query85	1731	299	268	268
query86	474	330	321	321
query87	3286	3151	3086	3086
query88	4055	2339	2344	2339
query89	480	375	369	369
query90	1728	192	188	188
query91	126	98	98	98
query92	66	50	49	49
query93	2411	502	505	502
query94	1076	187	189	187
query95	399	310	322	310
query96	591	275	271	271
query97	3222	3039	3036	3036
query98	225	201	195	195
query99	1188	868	852	852
Total cold run time: 269131 ms
Total hot run time: 173083 ms

doris-robot avatar Jun 14 '24 10:06 doris-robot

ClickBench: Total hot run time: 30.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 05dfa002cfc5f9a8084a7aa39170f4c58029679d, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.04	0.04
query4	1.68	0.10	0.08
query5	0.54	0.48	0.50
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.55	0.54
query11	0.16	0.10	0.11
query12	0.14	0.13	0.12
query13	0.58	0.58	0.59
query14	0.80	0.79	0.78
query15	0.84	0.81	0.80
query16	0.37	0.37	0.36
query17	0.99	0.97	0.94
query18	0.22	0.22	0.23
query19	1.84	1.68	1.69
query20	0.02	0.01	0.01
query21	15.41	0.66	0.66
query22	4.31	7.28	1.90
query23	18.32	1.38	1.28
query24	2.17	0.21	0.23
query25	0.16	0.08	0.09
query26	0.27	0.17	0.17
query27	0.09	0.09	0.08
query28	13.18	1.02	1.01
query29	12.64	3.29	3.28
query30	0.26	0.06	0.06
query31	2.87	0.39	0.38
query32	3.29	0.47	0.47
query33	2.86	2.92	2.89
query34	17.18	4.40	4.41
query35	4.49	4.46	4.54
query36	0.67	0.47	0.47
query37	0.18	0.16	0.15
query38	0.15	0.16	0.15
query39	0.05	0.03	0.03
query40	0.20	0.14	0.15
query41	0.09	0.05	0.04
query42	0.06	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.76 s
Total hot run time: 30.46 s

doris-robot avatar Jun 14 '24 10:06 doris-robot