doris icon indicating copy to clipboard operation
doris copied to clipboard

[hotfix](jdbc table) Restoring a table type that should not be deleted

Open zy-kkk opened this issue 1 year ago • 10 comments

Proposed changes

Issue Number: close #xxx

prefix #34986

We cannot directly delete fields in thrift, which will affect enumeration errors caused by version inconsistencies between FE and BE during upgrades.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

zy-kkk avatar May 27 '24 06:05 zy-kkk

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 27 '24 06:05 doris-robot

run buildall

zy-kkk avatar May 27 '24 06:05 zy-kkk

run buildall

zy-kkk avatar May 27 '24 06:05 zy-kkk

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

TPC-H: Total hot run time: 40919 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

------ Round 1 ----------------------------------
q1	17609	4476	4325	4325
q2	2020	189	193	189
q3	10468	1259	1282	1259
q4	10208	805	878	805
q5	7997	2724	2695	2695
q6	224	134	133	133
q7	966	606	621	606
q8	9269	2109	2102	2102
q9	8793	6492	6499	6492
q10	8876	3713	3739	3713
q11	452	248	248	248
q12	435	223	220	220
q13	17769	3007	2980	2980
q14	272	227	224	224
q15	521	485	464	464
q16	539	382	389	382
q17	984	674	678	674
q18	8186	7510	7485	7485
q19	6721	1552	1475	1475
q20	661	314	313	313
q21	4959	3860	3962	3860
q22	352	282	275	275
Total cold run time: 118281 ms
Total hot run time: 40919 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4409	4303	4224	4224
q2	387	270	266	266
q3	2999	2723	2772	2723
q4	1847	1585	1555	1555
q5	5293	5266	5323	5266
q6	214	124	128	124
q7	2152	1722	1749	1722
q8	3235	3320	3350	3320
q9	8366	8395	8361	8361
q10	3916	3706	3709	3706
q11	570	501	484	484
q12	749	604	609	604
q13	17479	3009	3013	3009
q14	306	267	263	263
q15	518	492	491	491
q16	488	439	429	429
q17	1795	1497	1477	1477
q18	7730	7574	7599	7574
q19	1671	1624	1590	1590
q20	1981	1803	1827	1803
q21	4799	4611	4692	4611
q22	568	503	479	479
Total cold run time: 71472 ms
Total hot run time: 54081 ms

doris-robot avatar May 27 '24 07:05 doris-robot

TPC-DS: Total hot run time: 168539 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

query1	910	395	378	378
query2	6457	2320	2528	2320
query3	6652	208	207	207
query4	19531	17291	17328	17291
query5	4144	414	411	411
query6	253	159	148	148
query7	4592	312	297	297
query8	243	177	192	177
query9	8467	2372	2354	2354
query10	451	281	269	269
query11	10585	10083	10148	10083
query12	136	95	89	89
query13	1653	398	363	363
query14	9412	7595	6149	6149
query15	210	163	166	163
query16	7829	273	255	255
query17	2135	537	515	515
query18	1962	281	268	268
query19	197	155	156	155
query20	94	88	100	88
query21	209	132	149	132
query22	4132	3907	3861	3861
query23	33371	33212	33047	33047
query24	12154	2922	2840	2840
query25	653	355	381	355
query26	1786	157	154	154
query27	3060	316	325	316
query28	7639	2021	2033	2021
query29	1140	633	617	617
query30	293	150	158	150
query31	967	780	760	760
query32	95	54	57	54
query33	802	266	266	266
query34	1033	463	462	462
query35	729	599	585	585
query36	1050	922	866	866
query37	271	67	67	67
query38	2936	2787	2748	2748
query39	862	797	786	786
query40	277	122	128	122
query41	46	45	44	44
query42	104	95	94	94
query43	588	578	556	556
query44	1215	757	745	745
query45	177	161	162	161
query46	1076	699	676	676
query47	1842	1766	1763	1763
query48	377	305	303	303
query49	1197	399	398	398
query50	778	388	394	388
query51	6916	6866	6759	6759
query52	110	95	86	86
query53	347	294	283	283
query54	997	429	430	429
query55	79	73	71	71
query56	263	235	242	235
query57	1111	1042	1023	1023
query58	240	210	207	207
query59	3608	3455	3203	3203
query60	276	250	260	250
query61	87	87	86	86
query62	681	452	460	452
query63	319	285	278	278
query64	9815	2215	1692	1692
query65	3191	3101	3114	3101
query66	1379	335	322	322
query67	15537	14824	14874	14824
query68	4501	532	522	522
query69	430	265	270	265
query70	1176	1135	1133	1133
query71	404	267	271	267
query72	7536	2687	2566	2566
query73	716	322	321	321
query74	6119	5596	5559	5559
query75	3429	2609	2605	2605
query76	2738	992	994	992
query77	569	264	261	261
query78	10371	9917	9790	9790
query79	2645	503	518	503
query80	1107	445	423	423
query81	500	224	218	218
query82	754	91	90	90
query83	233	165	168	165
query84	235	87	85	85
query85	1568	287	257	257
query86	489	299	312	299
query87	3347	3163	3150	3150
query88	4031	2450	2452	2450
query89	464	389	384	384
query90	1947	184	188	184
query91	125	99	93	93
query92	60	49	48	48
query93	1819	519	490	490
query94	1193	181	179	179
query95	399	306	311	306
query96	576	274	272	272
query97	3135	3011	2993	2993
query98	242	216	212	212
query99	1074	839	851	839
Total cold run time: 275660 ms
Total hot run time: 168539 ms

doris-robot avatar May 27 '24 08:05 doris-robot

ClickBench: Total hot run time: 30.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.05	0.06
query4	1.66	0.07	0.08
query5	0.52	0.49	0.48
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.56	0.56	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.76	0.76	0.80
query15	0.83	0.82	0.81
query16	0.38	0.37	0.37
query17	1.01	1.01	1.01
query18	0.22	0.24	0.25
query19	1.77	1.72	1.79
query20	0.02	0.01	0.01
query21	15.42	0.69	0.67
query22	4.97	7.15	1.72
query23	18.31	1.34	1.28
query24	2.04	0.19	0.21
query25	0.14	0.09	0.08
query26	0.26	0.16	0.17
query27	0.08	0.08	0.08
query28	13.38	1.01	1.00
query29	12.67	3.24	3.28
query30	0.24	0.07	0.06
query31	2.85	0.38	0.37
query32	3.30	0.48	0.47
query33	2.90	2.89	2.92
query34	17.11	4.44	4.41
query35	4.56	4.50	4.50
query36	0.66	0.46	0.46
query37	0.18	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.04	0.04
query40	0.16	0.14	0.14
query41	0.08	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.32 s
Total hot run time: 30.36 s

doris-robot avatar May 27 '24 08:05 doris-robot

run buildall

zy-kkk avatar May 28 '24 02:05 zy-kkk

TPC-H: Total hot run time: 40146 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

------ Round 1 ----------------------------------
q1	17941	5419	4341	4341
q2	2586	201	190	190
q3	10950	1277	1230	1230
q4	12360	826	834	826
q5	8426	2737	2695	2695
q6	215	131	132	131
q7	954	615	586	586
q8	9227	2070	2076	2070
q9	8798	6529	6526	6526
q10	8865	3737	3712	3712
q11	477	239	237	237
q12	478	226	221	221
q13	17785	2998	2948	2948
q14	274	223	231	223
q15	512	460	452	452
q16	484	376	371	371
q17	962	732	662	662
q18	7990	7622	7423	7423
q19	5270	1530	1543	1530
q20	655	301	316	301
q21	4935	3887	3195	3195
q22	346	276	279	276
Total cold run time: 120490 ms
Total hot run time: 40146 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4354	4208	4224	4208
q2	363	258	273	258
q3	2969	2789	2715	2715
q4	1872	1582	1568	1568
q5	5249	5271	5298	5271
q6	214	127	129	127
q7	2163	1784	1717	1717
q8	3191	3333	3311	3311
q9	8365	8381	8264	8264
q10	3872	3673	3640	3640
q11	593	478	502	478
q12	766	614	601	601
q13	17467	2992	2960	2960
q14	301	256	284	256
q15	533	484	484	484
q16	482	408	421	408
q17	1792	1494	1479	1479
q18	7943	7501	7451	7451
q19	1649	1541	1544	1541
q20	1978	1806	1798	1798
q21	4883	4664	4677	4664
q22	580	498	492	492
Total cold run time: 71579 ms
Total hot run time: 53691 ms

doris-robot avatar May 28 '24 03:05 doris-robot

TPC-DS: Total hot run time: 170309 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

query1	930	402	374	374
query2	6449	2487	2434	2434
query3	6662	201	205	201
query4	19306	17461	17387	17387
query5	4139	415	417	415
query6	251	159	153	153
query7	4588	292	286	286
query8	237	188	179	179
query9	8467	2346	2345	2345
query10	440	276	263	263
query11	10700	10232	10204	10204
query12	134	87	91	87
query13	1636	359	360	359
query14	10027	7550	7247	7247
query15	203	171	168	168
query16	7811	273	274	273
query17	1835	513	515	513
query18	1956	267	270	267
query19	193	153	151	151
query20	94	82	87	82
query21	195	130	131	130
query22	4273	4003	3887	3887
query23	33604	32897	32991	32897
query24	12139	2846	2897	2846
query25	669	351	376	351
query26	1795	155	153	153
query27	2974	319	314	314
query28	7779	2019	2020	2019
query29	1121	622	591	591
query30	281	148	146	146
query31	942	754	753	753
query32	96	55	56	55
query33	763	267	265	265
query34	1068	482	496	482
query35	736	609	616	609
query36	1083	902	913	902
query37	277	95	67	67
query38	2901	2799	2810	2799
query39	873	793	789	789
query40	277	130	125	125
query41	46	46	43	43
query42	106	98	98	98
query43	611	531	568	531
query44	1127	734	745	734
query45	183	168	162	162
query46	1075	716	706	706
query47	1866	1823	1796	1796
query48	378	296	295	295
query49	1219	382	384	382
query50	768	390	381	381
query51	6815	6661	6570	6570
query52	99	98	87	87
query53	355	290	277	277
query54	1004	428	431	428
query55	75	71	69	69
query56	291	269	239	239
query57	1121	1070	1069	1069
query58	239	225	221	221
query59	3496	3320	3332	3320
query60	277	264	254	254
query61	100	86	84	84
query62	644	448	447	447
query63	306	290	281	281
query64	9846	2200	1765	1765
query65	3175	3091	3080	3080
query66	1392	336	321	321
query67	15099	14907	14595	14595
query68	4526	533	525	525
query69	442	274	267	267
query70	1142	1130	1069	1069
query71	421	275	270	270
query72	7763	5550	2855	2855
query73	710	326	325	325
query74	6028	5726	5735	5726
query75	3510	2653	2675	2653
query76	2654	975	980	975
query77	409	275	271	271
query78	10411	10083	9822	9822
query79	3151	511	508	508
query80	2161	456	463	456
query81	542	226	226	226
query82	1550	96	94	94
query83	370	182	187	182
query84	270	91	94	91
query85	1659	326	315	315
query86	477	320	303	303
query87	3298	3104	3060	3060
query88	4713	2457	2456	2456
query89	493	401	385	385
query90	2001	188	192	188
query91	138	109	108	108
query92	66	49	51	49
query93	4066	509	492	492
query94	1233	211	187	187
query95	411	319	323	319
query96	597	277	268	268
query97	3240	2983	3047	2983
query98	253	222	226	222
query99	1244	856	863	856
Total cold run time: 281566 ms
Total hot run time: 170309 ms

doris-robot avatar May 28 '24 03:05 doris-robot

ClickBench: Total hot run time: 30.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 664f3e658888c880072fcb4b464e6cdefea59a57, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.50	0.49	0.50
query6	1.12	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.56	0.54	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.61
query14	0.77	0.78	0.79
query15	0.84	0.80	0.80
query16	0.35	0.37	0.36
query17	1.01	1.02	1.04
query18	0.23	0.23	0.25
query19	1.82	1.71	1.72
query20	0.01	0.00	0.01
query21	15.70	0.67	0.67
query22	4.06	7.72	2.01
query23	18.29	1.24	1.22
query24	1.59	0.38	0.20
query25	0.14	0.09	0.08
query26	0.26	0.18	0.17
query27	0.07	0.08	0.08
query28	13.40	1.09	1.04
query29	12.64	3.24	3.20
query30	0.24	0.06	0.06
query31	2.87	0.39	0.38
query32	3.28	0.48	0.47
query33	2.92	2.91	2.88
query34	16.97	4.37	4.46
query35	4.50	4.53	4.52
query36	0.65	0.47	0.46
query37	0.20	0.15	0.15
query38	0.16	0.14	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.16
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.08 s
Total hot run time: 30.63 s

doris-robot avatar May 28 '24 03:05 doris-robot