doris icon indicating copy to clipboard operation
doris copied to clipboard

[Configurations](multi-catalog)Fix enable_orc_filter_by_min_max functionality, the mistake for #35012.

Open kaka11chen opened this issue 1 year ago • 10 comments

Proposed changes

[Configurations] (multi-catalog)Fix enable_orc_filter_by_min_max functionality, the mistake for #35012.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

kaka11chen avatar May 23 '24 18:05 kaka11chen

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 23 '24 18:05 doris-robot

run buildall

kaka11chen avatar May 23 '24 18:05 kaka11chen

run buildall

kaka11chen avatar May 23 '24 18:05 kaka11chen

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 23 '24 18:05 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.65% (9018/25294) Line Coverage: 27.31% (74567/273046) Region Coverage: 26.54% (38593/145423) Branch Coverage: 23.40% (19688/84130) Coverage Report: http://coverage.selectdb-in.cc/coverage/3b286a15087f4c2470143ab35e71097c5a05ffbe_3b286a15087f4c2470143ab35e71097c5a05ffbe/report/index.html

doris-robot avatar May 23 '24 18:05 doris-robot

TPC-H: Total hot run time: 40767 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3b286a15087f4c2470143ab35e71097c5a05ffbe, data reload: false

------ Round 1 ----------------------------------
q1	17595	4310	4235	4235
q2	2022	190	201	190
q3	10445	1254	1168	1168
q4	10191	689	804	689
q5	7470	2673	2694	2673
q6	220	132	128	128
q7	966	600	607	600
q8	9224	2126	2086	2086
q9	9426	6663	6735	6663
q10	9088	3839	3897	3839
q11	465	246	239	239
q12	532	237	221	221
q13	18362	3173	3192	3173
q14	267	230	234	230
q15	516	490	462	462
q16	508	402	385	385
q17	951	702	688	688
q18	8409	7954	7827	7827
q19	5524	1546	1574	1546
q20	621	313	320	313
q21	5171	3146	4002	3146
q22	347	266	273	266
Total cold run time: 118320 ms
Total hot run time: 40767 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4554	4427	4377	4377
q2	367	270	270	270
q3	3117	2931	2913	2913
q4	1952	1612	1575	1575
q5	5349	5491	5453	5453
q6	217	129	128	128
q7	2170	1834	1775	1775
q8	3255	3396	3375	3375
q9	8563	8716	8621	8621
q10	4046	3701	3829	3701
q11	590	510	500	500
q12	787	599	650	599
q13	16158	3119	3124	3119
q14	310	273	269	269
q15	527	476	477	476
q16	486	442	430	430
q17	1815	1514	1510	1510
q18	7949	7731	7477	7477
q19	1665	1553	1531	1531
q20	2010	1833	1757	1757
q21	9669	4714	4665	4665
q22	568	460	477	460
Total cold run time: 76124 ms
Total hot run time: 54981 ms

doris-robot avatar May 23 '24 18:05 doris-robot

TPC-DS: Total hot run time: 168776 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3b286a15087f4c2470143ab35e71097c5a05ffbe, data reload: false

query1	919	373	375	373
query2	6764	2494	2422	2422
query3	6651	212	209	209
query4	19936	17425	17373	17373
query5	4114	436	428	428
query6	245	157	152	152
query7	4591	301	283	283
query8	241	185	182	182
query9	8580	2372	2352	2352
query10	452	273	254	254
query11	10565	10018	9997	9997
query12	133	88	86	86
query13	1634	352	355	352
query14	8486	7144	6872	6872
query15	215	169	168	168
query16	7731	272	259	259
query17	1384	530	520	520
query18	1940	278	268	268
query19	201	150	157	150
query20	95	85	83	83
query21	194	125	129	125
query22	4296	3973	3859	3859
query23	33628	32956	32983	32956
query24	6839	2922	2783	2783
query25	547	351	362	351
query26	705	154	155	154
query27	2072	337	317	317
query28	3727	2052	2036	2036
query29	835	601	591	591
query30	267	171	171	171
query31	964	758	738	738
query32	88	51	53	51
query33	493	290	258	258
query34	875	463	478	463
query35	701	619	611	611
query36	1056	912	912	912
query37	106	72	69	69
query38	2889	2785	2764	2764
query39	836	782	776	776
query40	205	125	121	121
query41	42	43	42	42
query42	109	90	95	90
query43	582	548	537	537
query44	1116	730	736	730
query45	180	160	164	160
query46	1042	726	731	726
query47	1844	1729	1781	1729
query48	366	299	285	285
query49	775	374	372	372
query50	773	380	371	371
query51	6900	6798	6784	6784
query52	109	85	92	85
query53	348	287	279	279
query54	536	430	429	429
query55	81	71	71	71
query56	263	236	245	236
query57	1129	1057	1028	1028
query58	224	207	213	207
query59	3338	3139	3029	3029
query60	283	259	249	249
query61	88	89	85	85
query62	573	476	454	454
query63	310	281	285	281
query64	8501	2279	1680	1680
query65	3157	3094	3068	3068
query66	784	332	322	322
query67	15259	14789	14596	14596
query68	4529	536	548	536
query69	443	261	261	261
query70	1149	1086	1149	1086
query71	383	264	268	264
query72	7668	2710	2558	2558
query73	711	367	326	326
query74	5945	5616	5682	5616
query75	3304	2606	2598	2598
query76	2158	1041	957	957
query77	402	264	271	264
query78	10169	9865	10046	9865
query79	2429	528	513	513
query80	976	443	432	432
query81	548	242	246	242
query82	968	100	96	96
query83	238	175	175	175
query84	261	87	89	87
query85	1039	278	260	260
query86	492	298	321	298
query87	3310	3113	3114	3113
query88	3685	2332	2325	2325
query89	479	390	395	390
query90	1991	196	195	195
query91	136	107	108	107
query92	63	52	51	51
query93	1857	517	508	508
query94	1151	198	196	196
query95	498	312	309	309
query96	596	263	264	263
query97	3202	3001	2990	2990
query98	245	226	222	222
query99	1128	859	877	859
Total cold run time: 257065 ms
Total hot run time: 168776 ms

doris-robot avatar May 23 '24 19:05 doris-robot

ClickBench: Total hot run time: 31.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3b286a15087f4c2470143ab35e71097c5a05ffbe, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.05	0.05
query4	1.69	0.07	0.07
query5	0.50	0.49	0.50
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.49	0.51
query10	0.52	0.56	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.76	0.76	0.78
query15	0.82	0.80	0.81
query16	0.36	0.36	0.37
query17	0.98	0.94	1.03
query18	0.21	0.25	0.25
query19	1.79	1.75	1.67
query20	0.02	0.01	0.01
query21	15.47	0.69	0.68
query22	4.32	6.43	2.63
query23	18.33	1.33	1.32
query24	2.08	0.20	0.20
query25	0.15	0.08	0.08
query26	0.26	0.16	0.17
query27	0.09	0.08	0.09
query28	13.32	1.02	1.00
query29	13.36	3.25	3.24
query30	0.24	0.06	0.05
query31	2.86	0.38	0.38
query32	3.30	0.47	0.46
query33	2.91	2.93	2.87
query34	17.21	4.45	4.43
query35	4.56	4.51	4.70
query36	0.64	0.46	0.46
query37	0.18	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.17	0.13	0.15
query41	0.10	0.05	0.04
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.49 s
Total hot run time: 31.22 s

doris-robot avatar May 23 '24 19:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 24 '24 02:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 24 '24 02:05 github-actions[bot]