doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](decimal) round result of decimal divide

Open jacktengg opened this issue 1 year ago • 6 comments

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

jacktengg avatar May 22 '24 14:05 jacktengg

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 22 '24 14:05 doris-robot

run buildall

jacktengg avatar May 22 '24 14:05 jacktengg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 22 '24 14:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 22 '24 14:05 github-actions[bot]

TPC-DS: Total hot run time: 171561 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cf1b955dd27e85f5eb222f2b467a2a14057edc9c, data reload: false

query1	924	370	366	366
query2	6321	2599	2474	2474
query3	6649	214	208	208
query4	19680	17813	17714	17714
query5	3906	432	420	420
query6	246	160	159	159
query7	4677	302	317	302
query8	232	197	186	186
query9	8763	2441	2419	2419
query10	429	280	255	255
query11	11087	10581	10624	10581
query12	121	80	88	80
query13	1657	376	366	366
query14	8532	7935	7900	7900
query15	272	176	181	176
query16	8200	281	292	281
query17	1734	573	539	539
query18	2048	282	277	277
query19	266	161	171	161
query20	88	91	79	79
query21	195	128	121	121
query22	4204	4053	4082	4053
query23	33745	33027	32929	32929
query24	10604	2833	2920	2833
query25	609	373	375	373
query26	1121	160	165	160
query27	2413	311	313	311
query28	7162	2058	2020	2020
query29	849	620	596	596
query30	220	171	171	171
query31	976	732	752	732
query32	83	51	51	51
query33	749	259	269	259
query34	1010	472	476	472
query35	711	622	599	599
query36	1060	905	922	905
query37	139	74	68	68
query38	2881	2794	2806	2794
query39	859	788	799	788
query40	196	146	124	124
query41	43	45	43	43
query42	101	101	98	98
query43	567	557	548	548
query44	1244	732	723	723
query45	178	154	158	154
query46	1079	700	725	700
query47	1886	1818	1767	1767
query48	362	291	295	291
query49	884	374	397	374
query50	752	385	393	385
query51	6946	6903	6741	6741
query52	102	92	87	87
query53	365	283	293	283
query54	861	422	413	413
query55	75	74	74	74
query56	264	240	246	240
query57	1144	1084	1038	1038
query58	252	205	205	205
query59	3365	3220	3267	3220
query60	278	261	266	261
query61	90	89	87	87
query62	652	437	457	437
query63	314	289	284	284
query64	8799	2212	1765	1765
query65	3131	3068	3106	3068
query66	809	318	323	318
query67	15493	14902	15093	14902
query68	6263	542	543	542
query69	511	277	270	270
query70	1211	1044	1131	1044
query71	498	269	278	269
query72	8003	3831	2530	2530
query73	808	320	322	320
query74	6062	5637	5542	5542
query75	4243	2621	2663	2621
query76	4345	1012	1019	1012
query77	687	267	271	267
query78	10335	10008	9781	9781
query79	2827	521	504	504
query80	1483	435	440	435
query81	559	250	239	239
query82	844	105	94	94
query83	202	175	225	175
query84	264	80	91	80
query85	1361	278	270	270
query86	460	326	308	308
query87	3344	3089	3127	3089
query88	3921	2344	2351	2344
query89	480	377	366	366
query90	1943	193	188	188
query91	146	96	97	96
query92	63	48	51	48
query93	2306	501	498	498
query94	1116	185	188	185
query95	399	314	305	305
query96	580	266	267	266
query97	3203	3085	2983	2983
query98	234	209	219	209
query99	1229	892	873	873
Total cold run time: 275584 ms
Total hot run time: 171561 ms

doris-robot avatar May 22 '24 15:05 doris-robot

ClickBench: Total hot run time: 30.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cf1b955dd27e85f5eb222f2b467a2a14057edc9c, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.06	0.05
query4	1.70	0.10	0.08
query5	0.50	0.49	0.50
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.48
query10	0.55	0.55	0.53
query11	0.16	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.59	0.60
query14	0.77	0.78	0.77
query15	0.82	0.82	0.82
query16	0.36	0.35	0.36
query17	0.93	0.93	0.93
query18	0.22	0.24	0.23
query19	1.78	1.71	1.66
query20	0.02	0.01	0.01
query21	15.73	0.66	0.65
query22	4.24	7.47	1.91
query23	18.30	1.39	1.24
query24	1.85	0.25	0.21
query25	0.14	0.08	0.08
query26	0.27	0.16	0.17
query27	0.09	0.07	0.07
query28	13.37	1.11	1.09
query29	13.13	3.29	3.29
query30	0.23	0.05	0.06
query31	2.87	0.39	0.39
query32	3.27	0.48	0.47
query33	2.87	2.92	2.91
query34	17.21	4.45	4.43
query35	4.43	4.76	4.56
query36	0.64	0.47	0.46
query37	0.17	0.15	0.16
query38	0.14	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.15	0.15
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.03	0.03	0.04
Total cold run time: 109.96 s
Total hot run time: 30.63 s

doris-robot avatar May 22 '24 15:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 23 '24 10:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 23 '24 10:05 github-actions[bot]

run buildall

jacktengg avatar Jun 18 '24 08:06 jacktengg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 18 '24 08:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 18 '24 08:06 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.48% (9004/24679) Line Coverage: 28.02% (73754/263192) Region Coverage: 27.50% (38319/139346) Branch Coverage: 24.19% (19524/80706) Coverage Report: http://coverage.selectdb-in.cc/coverage/24f1be8f45198296009effdc4d9b262123a63478_24f1be8f45198296009effdc4d9b262123a63478/report/index.html

doris-robot avatar Jun 18 '24 09:06 doris-robot

run buildall

jacktengg avatar Jun 19 '24 10:06 jacktengg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 19 '24 10:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 19 '24 10:06 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 36.46% (9005/24696) Line Coverage: 28.01% (73806/263460) Region Coverage: 27.50% (38349/139449) Branch Coverage: 24.19% (19541/80788) Coverage Report: http://coverage.selectdb-in.cc/coverage/9c9fb664888945a25d547fa5377784d87df1605a_9c9fb664888945a25d547fa5377784d87df1605a/report/index.html

doris-robot avatar Jun 19 '24 11:06 doris-robot

run performance

jacktengg avatar Jun 19 '24 14:06 jacktengg

TPC-H: Total hot run time: 40175 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c9fb664888945a25d547fa5377784d87df1605a, data reload: false

------ Round 1 ----------------------------------
q1	17602	4301	4319	4301
q2	2018	192	194	192
q3	10456	1087	1087	1087
q4	10190	747	825	747
q5	7454	2622	2620	2620
q6	217	140	138	138
q7	969	594	585	585
q8	9235	2041	2081	2041
q9	8863	6502	6423	6423
q10	8965	3705	3718	3705
q11	446	234	240	234
q12	464	230	226	226
q13	18010	2931	2955	2931
q14	256	214	224	214
q15	522	500	488	488
q16	525	385	376	376
q17	969	705	693	693
q18	7974	7388	7504	7388
q19	5055	1446	1414	1414
q20	679	316	318	316
q21	4842	3721	3840	3721
q22	391	335	337	335
Total cold run time: 116102 ms
Total hot run time: 40175 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4377	4203	4227	4203
q2	371	260	260	260
q3	3008	2856	2900	2856
q4	1957	1707	1654	1654
q5	5608	5549	5488	5488
q6	222	127	137	127
q7	2185	1837	1890	1837
q8	3272	3368	3404	3368
q9	8694	8638	8795	8638
q10	4036	3928	3715	3715
q11	599	497	492	492
q12	837	649	656	649
q13	17095	3172	3150	3150
q14	305	257	280	257
q15	517	493	483	483
q16	504	424	435	424
q17	1818	1530	1540	1530
q18	8113	7869	7705	7705
q19	1775	1520	1723	1520
q20	3125	1866	1889	1866
q21	4925	4874	4728	4728
q22	607	515	543	515
Total cold run time: 73950 ms
Total hot run time: 55465 ms

doris-robot avatar Jun 19 '24 15:06 doris-robot

run performance

jacktengg avatar Jun 20 '24 01:06 jacktengg

TPC-H: Total hot run time: 41409 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c9fb664888945a25d547fa5377784d87df1605a, data reload: false

------ Round 1 ----------------------------------
q1	17644	4269	4486	4269
q2	2035	195	196	195
q3	10430	1149	1146	1146
q4	10195	767	879	767
q5	7469	2700	2621	2621
q6	219	136	137	136
q7	954	621	614	614
q8	9360	2057	2083	2057
q9	9002	6516	6536	6516
q10	8930	3772	3782	3772
q11	1063	255	256	255
q12	454	239	246	239
q13	17976	3039	3015	3015
q14	272	223	229	223
q15	510	487	473	473
q16	540	394	378	378
q17	966	666	731	666
q18	8510	8062	7902	7902
q19	8977	1392	1512	1392
q20	685	355	337	337
q21	5168	4082	4452	4082
q22	436	354	362	354
Total cold run time: 121795 ms
Total hot run time: 41409 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4748	4640	4501	4501
q2	374	278	290	278
q3	3348	3019	3050	3019
q4	2028	1828	1784	1784
q5	5683	5687	5554	5554
q6	238	133	134	133
q7	2338	1826	1822	1822
q8	3305	3442	3418	3418
q9	8800	8715	8742	8715
q10	4087	3805	3848	3805
q11	635	488	501	488
q12	840	629	644	629
q13	16989	3061	3182	3061
q14	325	273	278	273
q15	547	476	490	476
q16	497	435	440	435
q17	1811	1526	1521	1521
q18	8025	7662	7924	7662
q19	1735	1715	1727	1715
q20	3104	1882	1869	1869
q21	5123	4894	4805	4805
q22	805	559	553	553
Total cold run time: 75385 ms
Total hot run time: 56516 ms

doris-robot avatar Jun 20 '24 02:06 doris-robot

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 21 '24 02:06 github-actions[bot]

run buildall

dataroaring avatar Jun 26 '24 12:06 dataroaring

TPC-H: Total hot run time: 39485 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c40fd8e5bd8c44b532858ffd3c82c0ea9b3d50a, data reload: false

------ Round 1 ----------------------------------
q1	17615	4311	4278	4278
q2	2026	189	184	184
q3	10443	1262	1079	1079
q4	10192	779	808	779
q5	7479	2620	2621	2620
q6	223	135	133	133
q7	943	585	594	585
q8	9226	2058	2039	2039
q9	9070	6468	6443	6443
q10	8993	3668	3716	3668
q11	460	231	241	231
q12	450	227	219	219
q13	19059	2960	2988	2960
q14	268	228	214	214
q15	518	496	485	485
q16	525	374	384	374
q17	958	675	689	675
q18	7954	7337	7330	7330
q19	4406	1405	1475	1405
q20	655	315	337	315
q21	4960	3143	3233	3143
q22	395	326	331	326
Total cold run time: 116818 ms
Total hot run time: 39485 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4339	4223	4235	4223
q2	361	269	275	269
q3	2962	2811	2920	2811
q4	1967	1794	1692	1692
q5	5593	5442	5498	5442
q6	227	125	126	125
q7	2164	1831	1861	1831
q8	3265	3369	3397	3369
q9	8701	8745	8821	8745
q10	4102	3926	3810	3810
q11	584	488	479	479
q12	806	676	667	667
q13	15764	3151	3141	3141
q14	292	280	255	255
q15	538	496	493	493
q16	505	440	445	440
q17	1791	1534	1504	1504
q18	8174	7876	7944	7876
q19	1776	1661	1627	1627
q20	2120	1867	1875	1867
q21	5096	5011	5069	5011
q22	598	563	549	549
Total cold run time: 71725 ms
Total hot run time: 56226 ms

doris-robot avatar Jun 26 '24 13:06 doris-robot

TPC-DS: Total hot run time: 173056 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c40fd8e5bd8c44b532858ffd3c82c0ea9b3d50a, data reload: false

query1	913	390	366	366
query2	6453	2570	2333	2333
query3	6633	204	209	204
query4	19413	17340	17437	17340
query5	3627	489	477	477
query6	259	168	165	165
query7	4591	292	293	292
query8	313	292	300	292
query9	8746	2473	2434	2434
query10	578	293	283	283
query11	10560	9855	10056	9855
query12	119	89	83	83
query13	1645	363	372	363
query14	10331	7753	6323	6323
query15	237	185	187	185
query16	7775	275	272	272
query17	1904	562	525	525
query18	1967	283	281	281
query19	201	154	160	154
query20	91	85	85	85
query21	221	133	132	132
query22	4406	3993	3951	3951
query23	33843	33613	33738	33613
query24	10665	2848	2892	2848
query25	615	400	401	400
query26	706	167	162	162
query27	2359	332	341	332
query28	6024	2149	2143	2143
query29	897	657	639	639
query30	237	160	167	160
query31	953	782	742	742
query32	94	59	59	59
query33	683	306	301	301
query34	880	482	505	482
query35	756	652	680	652
query36	1141	981	980	980
query37	145	77	73	73
query38	2989	2816	2761	2761
query39	906	814	820	814
query40	215	129	128	128
query41	56	54	58	54
query42	124	101	186	101
query43	575	569	556	556
query44	1069	756	727	727
query45	195	167	168	167
query46	1065	746	726	726
query47	1820	1752	1786	1752
query48	371	303	305	303
query49	848	403	419	403
query50	783	384	384	384
query51	7011	6730	6720	6720
query52	108	91	96	91
query53	358	288	292	288
query54	891	449	444	444
query55	73	73	76	73
query56	279	262	269	262
query57	1123	1036	1019	1019
query58	270	242	249	242
query59	3449	3093	3275	3093
query60	291	282	275	275
query61	99	95	89	89
query62	608	451	450	450
query63	316	289	287	287
query64	8532	2256	1759	1759
query65	3191	3128	3107	3107
query66	744	330	325	325
query67	15714	14872	14865	14865
query68	7231	568	538	538
query69	723	508	413	413
query70	1220	1164	1067	1067
query71	518	288	275	275
query72	8743	5502	5730	5502
query73	827	328	326	326
query74	5907	5572	5458	5458
query75	5005	2645	2644	2644
query76	4293	930	949	930
query77	776	286	347	286
query78	10581	9750	9683	9683
query79	7309	521	517	517
query80	989	463	467	463
query81	555	227	220	220
query82	792	110	101	101
query83	378	171	173	171
query84	275	88	86	86
query85	1298	281	276	276
query86	453	327	305	305
query87	3288	3135	3068	3068
query88	4690	2473	2447	2447
query89	481	391	388	388
query90	1779	235	187	187
query91	130	102	99	99
query92	62	53	50	50
query93	6217	510	508	508
query94	1139	188	194	188
query95	414	330	320	320
query96	620	270	269	269
query97	3206	3015	3048	3015
query98	239	212	194	194
query99	1129	816	825	816
Total cold run time: 286321 ms
Total hot run time: 173056 ms

doris-robot avatar Jun 26 '24 13:06 doris-robot

ClickBench: Total hot run time: 30.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c40fd8e5bd8c44b532858ffd3c82c0ea9b3d50a, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.69	0.07	0.08
query5	0.50	0.47	0.49
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.56	0.49	0.48
query10	0.55	0.55	0.55
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.58	0.59	0.60
query14	0.76	0.79	0.77
query15	0.86	0.82	0.82
query16	0.37	0.37	0.37
query17	1.05	0.99	1.03
query18	0.20	0.27	0.24
query19	1.93	1.79	1.75
query20	0.01	0.02	0.02
query21	15.43	0.74	0.67
query22	4.69	7.21	1.89
query23	18.30	1.26	1.30
query24	2.08	0.23	0.23
query25	0.16	0.10	0.08
query26	0.27	0.18	0.18
query27	0.08	0.09	0.09
query28	13.23	1.01	1.01
query29	12.64	3.27	3.22
query30	0.26	0.06	0.05
query31	2.88	0.39	0.39
query32	3.27	0.46	0.48
query33	2.91	2.96	2.91
query34	17.13	4.43	4.42
query35	4.52	4.51	4.52
query36	0.68	0.46	0.50
query37	0.18	0.16	0.16
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.17	0.15	0.13
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.19 s
Total hot run time: 30.66 s

doris-robot avatar Jun 26 '24 13:06 doris-robot

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

github-actions[bot] avatar Dec 24 '24 00:12 github-actions[bot]