doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](spill) incorrect revocable mem size of hash join

Open mrhhsg opened this issue 1 year ago • 5 comments

Proposed changes

Bug introduced by #34291

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

mrhhsg avatar May 02 '24 02:05 mrhhsg

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar May 02 '24 02:05 doris-robot

run buildall

mrhhsg avatar May 02 '24 02:05 mrhhsg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 02 '24 02:05 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 35.69% (8957/25099) Line Coverage: 27.29% (73907/270776) Region Coverage: 26.47% (38173/144186) Branch Coverage: 23.24% (19451/83706) Coverage Report: http://coverage.selectdb-in.cc/coverage/cb49722986a4901c36a7f534ff680596cfc24650_cb49722986a4901c36a7f534ff680596cfc24650/report/index.html

doris-robot avatar May 02 '24 03:05 doris-robot

TPC-DS: Total hot run time: 187387 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb49722986a4901c36a7f534ff680596cfc24650, data reload: false

query1	904	356	345	345
query2	6153	2368	2326	2326
query3	6667	206	209	206
query4	23232	21945	21802	21802
query5	3775	414	414	414
query6	261	175	167	167
query7	4639	310	294	294
query8	251	191	184	184
query9	8637	2365	2417	2365
query10	422	255	251	251
query11	15290	14744	14761	14744
query12	118	91	90	90
query13	1643	397	371	371
query14	8833	7673	7683	7673
query15	248	171	176	171
query16	8250	269	258	258
query17	1770	565	561	561
query18	2105	281	287	281
query19	342	150	148	148
query20	91	82	83	82
query21	188	127	125	125
query22	5061	4803	4842	4803
query23	34221	33079	33242	33079
query24	10328	2914	2900	2900
query25	594	380	382	380
query26	698	156	148	148
query27	2112	323	318	318
query28	5882	2018	2002	2002
query29	860	621	682	621
query30	260	148	147	147
query31	982	731	729	729
query32	87	50	52	50
query33	661	238	239	238
query34	889	474	470	470
query35	803	656	658	656
query36	1070	916	899	899
query37	103	67	64	64
query38	3201	2990	3051	2990
query39	1561	1575	1527	1527
query40	199	128	126	126
query41	42	37	36	36
query42	98	89	93	89
query43	584	544	536	536
query44	1101	736	737	736
query45	264	248	243	243
query46	1083	720	732	720
query47	1929	1845	1852	1845
query48	373	297	293	293
query49	848	384	396	384
query50	763	378	400	378
query51	6688	6695	6689	6689
query52	105	87	85	85
query53	351	275	278	275
query54	303	231	232	231
query55	80	75	74	74
query56	242	215	229	215
query57	1205	1112	1094	1094
query58	217	193	196	193
query59	3408	3206	3217	3206
query60	257	227	233	227
query61	86	85	85	85
query62	656	453	439	439
query63	310	278	278	278
query64	8334	7244	7216	7216
query65	3067	3060	3042	3042
query66	834	336	333	333
query67	15603	14996	15067	14996
query68	9661	545	559	545
query69	607	314	306	306
query70	1349	1105	1151	1105
query71	519	274	275	274
query72	8648	2523	2386	2386
query73	1582	323	320	320
query74	6496	6050	6101	6050
query75	4786	2647	2616	2616
query76	5821	1040	991	991
query77	677	265	265	265
query78	10977	10183	10323	10183
query79	11716	516	499	499
query80	1952	425	420	420
query81	488	225	215	215
query82	231	87	92	87
query83	199	161	160	160
query84	264	84	85	84
query85	894	307	256	256
query86	337	278	294	278
query87	3343	3053	3042	3042
query88	5401	2413	2410	2410
query89	508	368	377	368
query90	2042	183	182	182
query91	123	97	96	96
query92	55	49	46	46
query93	6692	511	502	502
query94	1263	181	178	178
query95	401	309	301	301
query96	616	270	264	264
query97	3119	2944	2963	2944
query98	239	220	213	213
query99	1179	858	895	858
Total cold run time: 304407 ms
Total hot run time: 187387 ms

doris-robot avatar May 02 '24 03:05 doris-robot

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar May 05 '24 13:05 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar May 05 '24 13:05 github-actions[bot]