doris icon indicating copy to clipboard operation
doris copied to clipboard

[Enhancement](Show Transaction) fix show transaction issue

Open GoGoWen opened this issue 1 year ago • 8 comments

Proposed changes

1, when use "show transaction where label="anything not exist" in doris, we will get "ERROR 1105 (HY000): errCode = 2, detailMessage = transaction with label delete does not exist". seems we just throw the exception.

we expect: Empty set (0.01 sec), and log the exception with warn log.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

GoGoWen avatar Apr 26 '24 07:04 GoGoWen

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

doris-robot avatar Apr 26 '24 07:04 doris-robot

run buildall

GoGoWen avatar Apr 26 '24 07:04 GoGoWen

TPC-H: Total hot run time: 40208 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0b4ef75ba90abdf4f2debbda074a4524a55cde78, data reload: false

------ Round 1 ----------------------------------
q1	17612	4289	4267	4267
q2	2021	190	185	185
q3	10473	1260	1224	1224
q4	10473	751	829	751
q5	7672	2749	2667	2667
q6	220	134	132	132
q7	949	538	539	538
q8	9321	2114	2061	2061
q9	9150	6779	6737	6737
q10	9581	3775	3744	3744
q11	458	236	243	236
q12	383	215	214	214
q13	18773	2917	2937	2917
q14	285	223	227	223
q15	492	489	468	468
q16	480	382	384	382
q17	959	658	714	658
q18	8035	7465	7477	7465
q19	1616	1547	1457	1457
q20	661	297	292	292
q21	5034	3967	3316	3316
q22	339	274	287	274
Total cold run time: 114987 ms
Total hot run time: 40208 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4308	4184	4194	4184
q2	370	263	269	263
q3	3031	2772	2742	2742
q4	1839	1552	1567	1552
q5	5304	5297	5300	5297
q6	209	123	124	123
q7	1747	1429	1428	1428
q8	3228	3374	3338	3338
q9	8734	8526	8565	8526
q10	3875	3729	3797	3729
q11	573	462	479	462
q12	751	589	578	578
q13	16335	2964	2923	2923
q14	306	274	271	271
q15	507	472	485	472
q16	481	417	423	417
q17	1743	1462	1457	1457
q18	7639	7651	7453	7453
q19	1625	1522	1554	1522
q20	1955	1783	1776	1776
q21	4875	4784	4737	4737
q22	529	493	468	468
Total cold run time: 69964 ms
Total hot run time: 53718 ms

doris-robot avatar Apr 26 '24 08:04 doris-robot

TPC-DS: Total hot run time: 186716 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0b4ef75ba90abdf4f2debbda074a4524a55cde78, data reload: false

query1	900	362	354	354
query2	6698	2465	2433	2433
query3	6660	204	207	204
query4	25989	21395	21221	21221
query5	4200	417	430	417
query6	282	184	178	178
query7	4588	288	289	288
query8	245	204	195	195
query9	8537	2329	2294	2294
query10	418	255	251	251
query11	14657	14181	14167	14167
query12	140	89	89	89
query13	1638	368	375	368
query14	8855	7949	7647	7647
query15	246	175	173	173
query16	8134	254	256	254
query17	1856	554	548	548
query18	2101	273	284	273
query19	194	150	152	150
query20	91	89	83	83
query21	197	131	130	130
query22	5002	4797	4760	4760
query23	33938	33345	33270	33270
query24	10804	2998	2978	2978
query25	628	375	366	366
query26	1558	159	153	153
query27	3005	318	318	318
query28	7710	1985	1984	1984
query29	940	608	603	603
query30	291	148	156	148
query31	977	757	736	736
query32	89	53	54	53
query33	742	254	241	241
query34	1066	481	479	479
query35	813	686	685	685
query36	1022	891	905	891
query37	138	70	68	68
query38	3118	3015	3053	3015
query39	1571	1546	1538	1538
query40	280	128	132	128
query41	43	39	39	39
query42	103	98	98	98
query43	552	558	524	524
query44	1252	720	742	720
query45	287	260	277	260
query46	1081	758	737	737
query47	1924	1818	1834	1818
query48	382	302	301	301
query49	1151	402	410	402
query50	776	403	387	387
query51	6800	6722	6849	6722
query52	100	97	88	88
query53	357	287	289	287
query54	317	238	239	238
query55	74	74	72	72
query56	242	221	229	221
query57	1192	1123	1133	1123
query58	238	211	215	211
query59	3539	3345	3241	3241
query60	250	237	244	237
query61	96	91	90	90
query62	662	441	442	441
query63	310	287	291	287
query64	9704	7255	7286	7255
query65	3187	3041	3053	3041
query66	1380	343	340	340
query67	15435	14787	14942	14787
query68	5232	529	549	529
query69	525	311	308	308
query70	1105	1121	1077	1077
query71	415	276	272	272
query72	8102	2658	2437	2437
query73	711	321	319	319
query74	6556	6098	6082	6082
query75	3574	2669	2647	2647
query76	3757	961	959	959
query77	638	266	268	266
query78	11026	10206	10278	10206
query79	7064	525	517	517
query80	1032	482	442	442
query81	498	224	225	224
query82	848	102	93	93
query83	207	166	172	166
query84	261	89	88	88
query85	1399	270	262	262
query86	413	301	303	301
query87	3247	3130	3091	3091
query88	4928	2349	2322	2322
query89	514	391	394	391
query90	1998	186	186	186
query91	130	101	96	96
query92	64	49	50	49
query93	5594	518	501	501
query94	1170	188	184	184
query95	388	311	299	299
query96	622	262	265	262
query97	3135	2989	2968	2968
query98	236	230	217	217
query99	1271	877	857	857
Total cold run time: 298412 ms
Total hot run time: 186716 ms

doris-robot avatar Apr 26 '24 08:04 doris-robot

Please add a regression test.

Done

GoGoWen avatar Apr 29 '24 07:04 GoGoWen

run buildall

GoGoWen avatar Apr 29 '24 07:04 GoGoWen

TPC-H: Total hot run time: 39725 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9af72ac660717af57a9a0263c95724426e9807b4, data reload: false

------ Round 1 ----------------------------------
q1	18071	4372	4216	4216
q2	2026	189	186	186
q3	10659	1232	1199	1199
q4	11475	829	799	799
q5	7583	2707	2686	2686
q6	213	133	139	133
q7	962	551	529	529
q8	9357	2122	2071	2071
q9	9415	6704	6671	6671
q10	9111	3687	3717	3687
q11	472	241	232	232
q12	472	222	221	221
q13	17768	2965	2931	2931
q14	272	227	221	221
q15	503	470	472	470
q16	520	372	374	372
q17	949	707	697	697
q18	8026	7243	7310	7243
q19	3974	1544	1504	1504
q20	647	307	318	307
q21	5009	3089	3959	3089
q22	341	261	277	261
Total cold run time: 117825 ms
Total hot run time: 39725 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4309	4226	4221	4221
q2	362	279	263	263
q3	3005	2789	2803	2789
q4	1888	1644	1591	1591
q5	5301	5320	5278	5278
q6	212	125	127	125
q7	1787	1407	1393	1393
q8	3201	3328	3341	3328
q9	8566	8518	8537	8518
q10	3857	3693	3682	3682
q11	577	469	474	469
q12	751	591	617	591
q13	17311	2939	2943	2939
q14	303	292	261	261
q15	518	495	476	476
q16	479	411	422	411
q17	1721	1465	1448	1448
q18	7734	7668	7346	7346
q19	1636	1539	1547	1539
q20	1953	1735	1775	1735
q21	9784	4835	4701	4701
q22	604	475	478	475
Total cold run time: 75859 ms
Total hot run time: 53579 ms

doris-robot avatar Apr 29 '24 08:04 doris-robot

TPC-DS: Total hot run time: 186510 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9af72ac660717af57a9a0263c95724426e9807b4, data reload: false

query1	899	355	348	348
query2	6451	2330	2485	2330
query3	6648	212	215	212
query4	23931	21154	21135	21135
query5	4200	431	429	429
query6	268	180	178	178
query7	4590	284	279	279
query8	246	183	188	183
query9	8549	2344	2327	2327
query10	435	245	237	237
query11	14738	14316	14248	14248
query12	139	90	83	83
query13	1624	359	364	359
query14	10508	8274	7520	7520
query15	276	164	175	164
query16	8205	255	259	255
query17	1911	558	535	535
query18	2098	271	286	271
query19	326	148	145	145
query20	91	85	82	82
query21	194	126	123	123
query22	5057	4862	4778	4778
query23	33784	33353	32932	32932
query24	10790	2921	2986	2921
query25	616	367	360	360
query26	1397	153	147	147
query27	2863	324	326	324
query28	7580	2010	1999	1999
query29	884	601	597	597
query30	295	156	149	149
query31	972	716	717	716
query32	94	53	58	53
query33	759	242	242	242
query34	1042	483	482	482
query35	825	690	677	677
query36	1098	896	906	896
query37	133	69	75	69
query38	3168	3024	3023	3023
query39	1614	1672	1552	1552
query40	246	126	127	126
query41	44	42	43	42
query42	106	96	104	96
query43	569	529	539	529
query44	1247	734	747	734
query45	295	267	285	267
query46	1080	716	697	697
query47	1972	1849	1899	1849
query48	370	296	279	279
query49	1044	390	392	390
query50	782	375	383	375
query51	6962	6826	6827	6826
query52	107	95	88	88
query53	349	276	281	276
query54	322	243	268	243
query55	81	77	80	77
query56	243	224	217	217
query57	1219	1123	1116	1116
query58	241	197	198	197
query59	3465	3378	3149	3149
query60	292	232	240	232
query61	92	90	90	90
query62	650	440	444	440
query63	307	274	276	274
query64	9652	7165	7183	7165
query65	3105	3045	3060	3045
query66	1407	337	342	337
query67	15537	15019	14752	14752
query68	5258	526	535	526
query69	475	305	312	305
query70	1176	1124	1120	1120
query71	399	269	303	269
query72	7674	2588	2448	2448
query73	698	324	323	323
query74	6498	6074	6130	6074
query75	3405	2666	2665	2665
query76	3345	992	944	944
query77	428	268	269	268
query78	11063	10180	10108	10108
query79	3127	514	523	514
query80	1960	433	430	430
query81	527	224	223	223
query82	770	96	88	88
query83	271	173	174	173
query84	265	81	89	81
query85	2098	278	299	278
query86	489	279	303	279
query87	3291	3100	3161	3100
query88	4497	2322	2338	2322
query89	489	385	360	360
query90	2023	185	188	185
query91	127	97	101	97
query92	64	49	47	47
query93	5000	514	508	508
query94	1269	183	186	183
query95	1100	1093	1090	1090
query96	600	268	262	262
query97	3144	2905	2932	2905
query98	240	219	213	213
query99	1254	854	861	854
Total cold run time: 294108 ms
Total hot run time: 186510 ms

doris-robot avatar Apr 29 '24 08:04 doris-robot