doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](join) incorrect result of mark join in nested loop join (#31280)

Open mrhhsg opened this issue 1 year ago • 3 comments

Proposed changes

pick #31280 from master into branch-2.0

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

mrhhsg avatar Feb 24 '24 02:02 mrhhsg

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

doris-robot avatar Feb 24 '24 02:02 doris-robot

run buildall

mrhhsg avatar Feb 24 '24 02:02 mrhhsg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 24 '24 02:02 github-actions[bot]

run buildall

mrhhsg avatar Feb 25 '24 14:02 mrhhsg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 25 '24 14:02 github-actions[bot]

TeamCity be ut coverage result: Function Coverage: 37.81% (8037/21255) Line Coverage: 29.50% (65562/222264) Region Coverage: 28.96% (33729/116470) Branch Coverage: 24.81% (17310/69766) Coverage Report: http://coverage.selectdb-in.cc/coverage/3996659413abf0b401d880d71f2773d955d6dc23_3996659413abf0b401d880d71f2773d955d6dc23/report/index.html

doris-robot avatar Feb 25 '24 14:02 doris-robot

TPC-H: Total hot run time: 50015 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3996659413abf0b401d880d71f2773d955d6dc23, data reload: false

------ Round 1 ----------------------------------
q1	17857	4369	4314	4314
q2	2056	153	138	138
q3	10400	1834	1867	1834
q4	10399	1232	1299	1232
q5	8466	3992	3988	3988
q6	229	123	122	122
q7	2024	1607	1619	1607
q8	9269	2697	2695	2695
q9	11024	10785	10761	10761
q10	8631	3550	3478	3478
q11	435	243	238	238
q12	465	294	302	294
q13	18335	3978	4033	3978
q14	345	331	316	316
q15	503	453	455	453
q16	684	593	590	590
q17	1110	944	942	942
q18	7257	6754	6884	6754
q19	1677	1525	1492	1492
q20	510	309	297	297
q21	4480	4106	4125	4106
q22	495	386	396	386
Total cold run time: 116651 ms
Total hot run time: 50015 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4324	4307	4292	4292
q2	319	218	224	218
q3	4205	4133	4135	4133
q4	2762	2746	2725	2725
q5	7381	7201	7224	7201
q6	235	119	116	116
q7	3161	2787	2836	2787
q8	4351	4478	4446	4446
q9	17583	17269	17283	17269
q10	4263	4242	4253	4242
q11	768	673	662	662
q12	1015	851	848	848
q13	6233	3726	3803	3726
q14	452	412	417	412
q15	492	461	455	455
q16	746	695	689	689
q17	3801	3784	3813	3784
q18	8710	8671	8835	8671
q19	1695	1708	1649	1649
q20	2414	2139	2072	2072
q21	8494	8498	8429	8429
q22	1038	963	954	954
Total cold run time: 84442 ms
Total hot run time: 79780 ms

doris-robot avatar Feb 25 '24 14:02 doris-robot

TPC-DS: Total hot run time: 201224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3996659413abf0b401d880d71f2773d955d6dc23, data reload: false

query1	919	397	382	382
query2	6520	2088	2146	2088
query3	6915	209	204	204
query4	20210	17805	17833	17805
query5	19706	6490	6468	6468
query6	286	214	229	214
query7	4143	301	298	298
query8	263	268	233	233
query9	3076	2695	2604	2604
query10	437	287	291	287
query11	11339	10622	10597	10597
query12	120	75	72	72
query13	5589	654	626	626
query14	17699	12816	13124	12816
query15	364	236	230	230
query16	6449	257	269	257
query17	1734	1449	866	866
query18	2307	410	404	404
query19	214	138	144	138
query20	79	80	74	74
query21	187	97	87	87
query22	5159	5022	4993	4993
query23	32447	32024	32154	32024
query24	6915	6510	6457	6457
query25	519	425	422	422
query26	532	164	164	164
query27	1881	292	286	286
query28	6038	2225	2182	2182
query29	2902	2647	2619	2619
query30	238	161	158	158
query31	922	726	760	726
query32	61	59	55	55
query33	399	249	251	249
query34	839	468	481	468
query35	1113	966	959	959
query36	1742	1599	1972	1599
query37	90	58	56	56
query38	3130	2931	2937	2931
query39	1371	1333	1312	1312
query40	198	97	97	97
query41	34	31	35	31
query42	86	81	87	81
query43	589	627	583	583
query44	1113	710	724	710
query45	242	231	220	220
query46	1236	955	964	955
query47	1826	1686	1827	1686
query48	982	684	666	666
query49	618	363	370	363
query50	870	605	611	605
query51	4737	4641	4585	4585
query52	84	85	77	77
query53	438	311	315	311
query54	2663	2457	2481	2457
query55	86	87	85	85
query56	226	211	198	198
query57	1098	1105	1171	1105
query58	196	187	196	187
query59	3708	3256	3272	3256
query60	203	185	202	185
query61	84	85	82	82
query62	793	512	464	464
query63	463	335	330	330
query64	2475	1493	1385	1385
query65	3630	3543	3548	3543
query66	820	367	371	367
query67	15912	18025	15455	15455
query68	8495	659	658	658
query69	548	351	344	344
query70	2034	1696	1879	1696
query71	387	290	311	290
query72	6504	3450	3450	3450
query73	730	327	329	327
query74	6331	5936	5821	5821
query75	4900	3687	3746	3687
query76	4938	1162	1118	1118
query77	729	252	260	252
query78	12682	11409	11927	11409
query79	9476	638	641	638
query80	1949	383	378	378
query81	488	232	224	224
query82	1649	99	96	96
query83	174	133	134	133
query84	270	68	68	68
query85	1046	278	289	278
query86	394	369	381	369
query87	3215	3004	2975	2975
query88	5128	2330	2329	2329
query89	393	287	300	287
query90	1863	202	209	202
query91	164	113	129	113
query92	57	48	50	48
query93	6170	625	544	544
query94	746	198	204	198
query95	1106	1065	1069	1065
query96	646	324	325	324
query97	6580	6387	6440	6387
query98	182	171	175	171
query99	2866	872	866	866
Total cold run time: 313104 ms
Total hot run time: 201224 ms

doris-robot avatar Feb 25 '24 14:02 doris-robot

ClickBench: Total hot run time: 30.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3996659413abf0b401d880d71f2773d955d6dc23, data reload: false

query1	0.02	0.02	0.03
query2	0.06	0.02	0.02
query3	0.25	0.05	0.05
query4	1.82	0.06	0.07
query5	0.54	0.51	0.52
query6	1.29	0.61	0.62
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.53	0.47	0.48
query10	0.53	0.54	0.53
query11	0.12	0.08	0.09
query12	0.11	0.09	0.09
query13	0.61	0.62	0.61
query14	0.79	0.78	0.79
query15	0.76	0.76	0.76
query16	0.36	0.36	0.39
query17	1.01	1.02	1.03
query18	0.23	0.25	0.26
query19	1.87	1.83	1.76
query20	0.01	0.01	0.00
query21	15.49	0.56	0.56
query22	1.95	1.96	1.59
query23	17.27	1.11	0.83
query24	5.83	0.95	0.99
query25	1.52	0.11	0.11
query26	0.25	0.14	0.13
query27	0.10	0.11	0.11
query28	7.25	0.77	0.71
query29	12.71	2.35	2.40
query30	0.55	0.54	0.53
query31	2.82	0.37	0.39
query32	3.38	0.49	0.49
query33	3.04	3.10	3.08
query34	15.23	4.82	4.82
query35	4.88	4.88	4.90
query36	1.06	1.03	1.01
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.13
query41	0.06	0.01	0.01
query42	0.02	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 104.67 s
Total hot run time: 30.77 s

doris-robot avatar Feb 25 '24 15:02 doris-robot

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 3996659413abf0b401d880d71f2773d955d6dc23 with default session variables
Stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

doris-robot avatar Feb 25 '24 15:02 doris-robot