doris icon indicating copy to clipboard operation
doris copied to clipboard

[feature](array_function) add support for array_popfront

Open bobhan1 opened this issue 2 years ago • 5 comments

Proposed changes

Issue Number: #17361

Problem summary

Describe your changes.

Checklist(Required)

  • [x] Does it affect the original behavior
  • [x] Has unit tests been added
  • [x] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

bobhan1 avatar Mar 04 '23 11:03 bobhan1

@Yukang-Lian

bobhan1 avatar Mar 04 '23 11:03 bobhan1

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 11:03 github-actions[bot]

Please add regression tests and docs.

Done

bobhan1 avatar Mar 04 '23 13:03 bobhan1

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 13:03 github-actions[bot]

Please add regression tests and docs.

Done

We need add test results to this PR, plz follow this guide to generate .out file.

https://doris.incubator.apache.org/zh-CN/community/developer-guide/regression-testing#%E4%BD%BF%E7%94%A8%E6%9F%A5%E8%AF%A2%E7%BB%93%E6%9E%9C%E8%87%AA%E5%8A%A8%E7%94%9F%E6%88%90out%E6%96%87%E4%BB%B6

Yukang-Lian avatar Mar 04 '23 13:03 Yukang-Lian

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 05 '23 00:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 05 '23 02:03 github-actions[bot]

run buildall

Yukang-Lian avatar Mar 05 '23 02:03 Yukang-Lian

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 05 '23 02:03 github-actions[bot]

seems p0 regression failed

eldenmoon avatar Mar 07 '23 03:03 eldenmoon

run buildall

bobhan1 avatar Mar 07 '23 05:03 bobhan1

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]

run buildall

bobhan1 avatar Mar 07 '23 08:03 bobhan1

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]

run buildall

Yukang-Lian avatar Mar 07 '23 09:03 Yukang-Lian

这个FE UT build failure从日志好像看不出什么,是还需要再重跑一遍吗

bobhan1 avatar Mar 07 '23 13:03 bobhan1

run feut

Yukang-Lian avatar Mar 07 '23 13:03 Yukang-Lian

regression test似乎又因为一些其他原因挂了?

bobhan1 avatar Mar 08 '23 01:03 bobhan1

regression test似乎又因为一些其他原因挂了?

regression test似乎又因为一些其他原因挂了?

我rebase一下再推试试

bobhan1 avatar Mar 08 '23 01:03 bobhan1

run p0

bobhan1 avatar Mar 08 '23 01:03 bobhan1