doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](rebalance) fix that the clone operation is not performed due to incorrect condition judgment

Open liaoxin01 opened this issue 2 years ago • 9 comments

Proposed changes

Issue Number: close #xxx

Problem summary

the clone operation is not performed due to incorrect condition judgment. introduce by: #16889

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

liaoxin01 avatar Mar 03 '23 03:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 04:03 github-actions[bot]

run buildall

liaoxin01 avatar Mar 03 '23 04:03 liaoxin01

LGTM

platoneko avatar Mar 03 '23 04:03 platoneko

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.82 seconds stream load tsv: 474 seconds loaded 74807831229 Bytes, about 150 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230304045111_clickbench_pr_108386.html

hello-stephen avatar Mar 03 '23 05:03 hello-stephen

run p0

platoneko avatar Mar 03 '23 07:03 platoneko

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 03 '23 13:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 03 '23 13:03 github-actions[bot]

run buildall

liaoxin01 avatar Mar 04 '23 04:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 04 '23 04:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 05 '23 02:03 github-actions[bot]

run p0

dataroaring avatar Mar 05 '23 02:03 dataroaring