doris icon indicating copy to clipboard operation
doris copied to clipboard

[opt](string) optimize string equal comparision

Open jacktengg opened this issue 2 years ago • 4 comments

Proposed changes

Issue Number: close #xxx

Problem summary

Optimize string equal and not-equal comparison by using memequal_small_allow_overflow15.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

jacktengg avatar Mar 02 '23 08:03 jacktengg

run buildall

jacktengg avatar Mar 02 '23 08:03 jacktengg

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 08:03 github-actions[bot]

run buildall

jacktengg avatar Mar 02 '23 08:03 jacktengg

Please give some performance result, before and after this pr.

cambyzju avatar Mar 02 '23 09:03 cambyzju