[fix](merge-on-write) fix that delete bitmap is not calculated correctly when clone tablet

Open liaoxin01 opened this issue 2 years ago • 4 comments

Proposed changes

Issue Number: close #xxx

Problem summary

Because of specified_rowset_ids is nullptr, the delete bitmap is not be recalculated when clone, introduced by #14995.
Optimize delete bitmap calculation of full clone, by clone the delete bitmap of remote tablet.
Change the set operation of delete bitmap into a merge operation.
Delete some useless code.

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Mar 02 '23 07:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

Mar 02 '23 07:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

Mar 03 '23 11:03 github-actions[bot]

run buildall

Mar 04 '23 04:03 liaoxin01

clang-tidy review says "All clean, LGTM! :+1:"

Mar 04 '23 04:03 github-actions[bot]

PR approved by at least one committer and no changes requested.

Mar 05 '23 03:03 github-actions[bot]

PR approved by anyone and no changes requested.

Mar 05 '23 03:03 github-actions[bot]