doris icon indicating copy to clipboard operation
doris copied to clipboard

[Refactor](map) remove using column array in map to reduce offset column

Open amorynan opened this issue 2 years ago • 5 comments

Proposed changes

  1. remove column array in map
  2. add offsets column in map Aim to reduce duplicate offset from key-array and value-array in disk

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

amorynan avatar Mar 02 '23 06:03 amorynan

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 07:03 github-actions[bot]

run buildall

amorynan avatar Mar 02 '23 09:03 amorynan

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 09:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 03 '23 09:03 github-actions[bot]

run buildall

amorynan avatar Mar 03 '23 14:03 amorynan

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 06 '23 07:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 06 '23 07:03 github-actions[bot]

run buildall

amorynan avatar Mar 06 '23 09:03 amorynan

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 06 '23 23:03 github-actions[bot]

run buildall

amorynan avatar Mar 07 '23 00:03 amorynan

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 07 '23 08:03 github-actions[bot]

run buildall

amorynan avatar Mar 07 '23 22:03 amorynan

please rebase master

xy720 avatar Mar 08 '23 02:03 xy720

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 08 '23 07:03 github-actions[bot]

run buildall

amorynan avatar Mar 08 '23 09:03 amorynan

run p1

amorynan avatar Mar 08 '23 13:03 amorynan

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 09 '23 03:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 09 '23 03:03 github-actions[bot]