doris icon indicating copy to clipboard operation
doris copied to clipboard

[vectorized](bug) fix array constructor function change origin column from block

Open zhangstar333 opened this issue 2 years ago • 8 comments

when get a column from block, and calculate result column don't need to change the origin column, maybe it's still need used.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

zhangstar333 avatar Mar 01 '23 10:03 zhangstar333

run buildall

zhangstar333 avatar Mar 01 '23 10:03 zhangstar333

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 01 '23 10:03 github-actions[bot]

ADD test for the case

HappenLee avatar Mar 01 '23 15:03 HappenLee

please add test case

morningman avatar Mar 02 '23 01:03 morningman

run buildall

zhangstar333 avatar Mar 02 '23 03:03 zhangstar333

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 02 '23 03:03 github-actions[bot]

run p0

zhangstar333 avatar Mar 02 '23 08:03 zhangstar333

run p0

zhangstar333 avatar Mar 03 '23 02:03 zhangstar333

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 06 '23 03:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 06 '23 03:03 github-actions[bot]