doris icon indicating copy to clipboard operation
doris copied to clipboard

[refactor](function) refine function geo

Open Gabriel39 opened this issue 2 years ago • 3 comments

Proposed changes

remove unused constant args

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Gabriel39 avatar Mar 01 '23 08:03 Gabriel39

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 01 '23 08:03 github-actions[bot]

run buildall

Gabriel39 avatar Mar 01 '23 08:03 Gabriel39

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.81 seconds stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230301094859_clickbench_pr_106308.html

hello-stephen avatar Mar 01 '23 09:03 hello-stephen