doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](fe)support multi distinct group_concat

Open starocean999 opened this issue 2 years ago • 5 comments

Proposed changes

  1. group_concat(distinct x, order by y) is not correctly implemented, return an error message "not support" for now
  2. support multi distinct group_concat to allow select group_concat(distinct a), group_concat(disinct b) from t;

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

starocean999 avatar Feb 28 '23 09:02 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 09:02 github-actions[bot]

run buildall

starocean999 avatar Feb 28 '23 09:02 starocean999

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 32.9 seconds stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230228141350_clickbench_pr_105815.html

hello-stephen avatar Feb 28 '23 09:02 hello-stephen

run buildall

starocean999 avatar Feb 28 '23 13:02 starocean999

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 13:02 github-actions[bot]

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Mar 02 '23 09:03 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Mar 02 '23 09:03 github-actions[bot]