doris icon indicating copy to clipboard operation
doris copied to clipboard

[enhancement]optimize some bitmap function logic

Open ucasfl opened this issue 2 years ago • 5 comments

Proposed changes

Issue Number: close #xxx

Optimize logic of bitmap function bitmap_subset_in_range and bitmap_subset_limit: pass arguments by value for basic type, and reduce branch stantement for better vectorization.

Problem summary

Describe your changes.

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

ucasfl avatar Feb 28 '23 03:02 ucasfl

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 03:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 06:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 28 '23 07:02 github-actions[bot]

Please describe your change

morningman avatar Mar 01 '23 01:03 morningman

Please describe your change

done.

ucasfl avatar Mar 01 '23 06:03 ucasfl