doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](decimal) change log fatal to log warning to avoid code dump on decimal type

Open liaoxin01 opened this issue 2 years ago • 4 comments

Proposed changes

Issue Number: close #xxx

Problem summary

cherry-pick from: #14150

Checklist(Required)

  • [ ] Does it affect the original behavior
  • [ ] Has unit tests been added
  • [ ] Has document been added or modified
  • [ ] Does it need to update dependencies
  • [ ] Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

liaoxin01 avatar Feb 21 '23 06:02 liaoxin01

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Feb 22 '23 13:02 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Feb 22 '23 13:02 github-actions[bot]

buildall

yiguolei avatar Feb 23 '23 00:02 yiguolei

I think we should use log fatal here, because it will return a wrong result when decimal overflow. If user is using insert into select to do ETL jobs, then data is wrong.

yiguolei avatar Feb 23 '23 00:02 yiguolei