doris icon indicating copy to clipboard operation
doris copied to clipboard

[enhancement](rewrite) add OrToIn rule && fix expr clone problems

Open Henry2SS opened this issue 3 years ago • 1 comments

Proposed changes

Issue Number: close #12871

Problem summary

  1. support Or to In rewrite rule
  2. fix Expr clone problems. It should create a new object, or it will always be shallow-copy.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [x] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [x] Yes
    • [ ] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [x] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [x] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Henry2SS avatar Sep 22 '22 10:09 Henry2SS

  1. fe unit-tests passed locally.
  2. compiled and manually tested function passed

test results:

image

image

Henry2SS avatar Sep 22 '22 10:09 Henry2SS

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Dec 10 '22 11:12 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Dec 10 '22 11:12 github-actions[bot]

TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.65 seconds load time: 638 seconds storage size: 17123113066 Bytes https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221227102546_clickbench_pr_69344.html

hello-stephen avatar Dec 12 '22 10:12 hello-stephen

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Dec 27 '22 10:12 github-actions[bot]

It seems this PR introduced an unstable test, please see http://43.132.222.7:8111/viewLog.html?buildId=69682&buildTypeId=Doris_Doris_FeUt cc @caiconghui @morrySnow

wangshuo128 avatar Dec 28 '22 02:12 wangshuo128