doris icon indicating copy to clipboard operation
doris copied to clipboard

[fix](checksum) checksum should respect DELETE_SIGN column

Open dataroaring opened this issue 3 years ago • 1 comments

If checksum does not respect DELETE_SIGN column, then is 2 replicas' compaction status is not same, then they may generate different checksums probabaly.

BTW: We change checksum to vectorized engine.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • [ ] Yes
    • [ ] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [ ] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [ ] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [ ] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

dataroaring avatar Aug 27 '22 13:08 dataroaring

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

github-actions[bot] avatar Mar 01 '23 00:03 github-actions[bot]