doris icon indicating copy to clipboard operation
doris copied to clipboard

[refactor](array-type) optimize the array_distinct and array_sort fun…

Open carlvinhust2012 opened this issue 3 years ago • 1 comments

Proposed changes

  1. this pr is used to optimize the array_distinct and array_sort function.

Issue Number: close #10052

Problem Summary:

Checklist(Required)

  1. Type of your changes:
    • [ ] Improvement
    • [ ] Fix
    • [ ] Feature-WIP
    • [ ] Feature
    • [ ] Doc
    • [x] Refator
    • [ ] Others:
  2. Does it affect the original behavior:
    • [ ] Yes
    • [x] No
    • [ ] I don't know
  3. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  4. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [x] No Need
  5. Does it need to update dependencies:
    • [ ] Yes
    • [x] No
  6. Are there any changes that cannot be rolled back:
    • [ ] Yes
    • [x] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

carlvinhust2012 avatar Jul 28 '22 12:07 carlvinhust2012

There are still much duplicate code between function_array_sort.cpp and function_array_distinct.cpp. Is there any good idea to extract these code out?

ok,I will re-check again.

carlvinhust2012 avatar Jul 29 '22 06:07 carlvinhust2012