[Improvement-17057][Master] Check if the WorkflowGrapth is a dag at constructor

[yingh0ng]

Purpose of the pull request

Check if the WorkflowGrapth is a dag close #17057

Brief change log

Conclusion: A graph is not a DAG if its task length is less than the total number of tasks after topological sorting

Verify this pull request

This change added tests and can be verified as follows:

• WorkflowGraphCheckIfDAGTest

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

[boring-cyborg[bot]]

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

[yingh0ng]

Update: When a ring exists, it is not a DAG

[yingh0ng]

@SbloodyS Hello, please take a look.

[yingh0ng]

@SbloodyS The Mergeable check failed because this PR was not added to the milestone.

[yingh0ng]

@ruanwenjun PTAL

[sonarqubecloud[bot]]

Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[yingh0ng]

@ruanwenjun @SbloodyS PTAL

[yingh0ng]

Can somebody review this again.

[sonarqubecloud[bot]]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

[SbloodyS]

Closing for inactivity.