dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement-16947][UI] Task instance log details should always stay at the bottom

Open imizao opened this issue 1 year ago • 12 comments

Purpose of the pull request

Task instance log details should always stay at the bottom.

close #16975

Brief change log

The log details area for task instances should always remain scrolled to the bottom, allowing users to view the latest log output in real-time.

Final effect 1 12.gif

Final effect 2 123.gif

Verify this pull request

This pull request is code cleanup without any test coverage.

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

imizao avatar Jan 07 '25 09:01 imizao

Please follow the pull request notice first.

Well, should I use it like this? [Improvement-16947][UI] Task instance log details should always stay at the bottom

imizao avatar Jan 08 '25 02:01 imizao

I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

imizao avatar Jan 08 '25 02:01 imizao

I think this feature needs disscussion. No all users needs this when the log is very large and refresh very fast.

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

Like this. 12345.gif

imizao avatar Jan 08 '25 02:01 imizao

Please follow the pull request notice first.

Well, should I use it like this? [Improvement-16947][UI] Task instance log details should always stay at the bottom

You can take a look at https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md

SbloodyS avatar Jan 09 '25 02:01 SbloodyS

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

I think it's a good idea.

SbloodyS avatar Jan 09 '25 02:01 SbloodyS

Add a button that allows the user to manually control whether to scroll to the bottom, without forcing automatic scrolling. Would that work?

I think it's a good idea.

The code has been submitted

imizao avatar Jan 13 '25 10:01 imizao

You didn't create a new improvement issue and link to this PR. @imizao

SbloodyS avatar Jan 21 '25 06:01 SbloodyS

Generally LGTM. Just some NIT.

Fixed the NITs, thanks for the suggestions!

imizao avatar Jan 22 '25 10:01 imizao

You didn't create a new improvement issue and link to this PR. @imizao

This PR addresses #16975

imizao avatar Jan 22 '25 10:01 imizao

The Final effect 1 and Final effect 2 is strange, shouldn't show the response over and over again, there is no log content here.

ruanwenjun avatar Jan 24 '25 06:01 ruanwenjun

image

I found that the submitted code is incomplete,can the page refresh automatically when the mouse reaches the bottom so that I don't have to manually update it?

sdhzwc avatar Mar 28 '25 03:03 sdhzwc

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jul 29 '25 00:07 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Aug 06 '25 00:08 github-actions[bot]