Reduced cognitive complexity of ProcessDefinitionServiceImpl class
Purpose of the pull request
For issue #15599 This PR reduces cognitive complexity of ProcessDefinitionServiceImpl in dolphin-scheduler-api.
below methods in this class are covered
- importSqlProcessDefinition
- doBatchOperateProcessDefinition
Verify this pull request
This pull request is code cleanup without any test coverage.
Codecov Report
Attention: Patch coverage is 54.67626% with 63 lines in your changes are missing coverage. Please review.
Project coverage is 39.23%. Comparing base (
08ac132) to head (f3e1621).
:exclamation: Current head f3e1621 differs from pull request most recent head 39e8dd3. Consider uploading reports for the commit 39e8dd3 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| ...api/service/impl/ProcessDefinitionServiceImpl.java | 54.67% | 49 Missing and 14 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #15729 +/- ##
============================================
- Coverage 39.25% 39.23% -0.02%
- Complexity 4912 4916 +4
============================================
Files 1323 1323
Lines 45191 45210 +19
Branches 4812 4810 -2
============================================
+ Hits 17738 17739 +1
- Misses 25570 25587 +17
- Partials 1883 1884 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please retry analysis of this Pull-Request directly on SonarCloud