dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature][Parameter] Add project-level parameters

Open rickchengx opened this issue 2 years ago • 11 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

  • Currently, DS has local and global parameters. Note that Global parameters only take effect inside the workflow
  • Add project-level parameters so that all workflows under the same project can use these project-level parameters

Why we need project-level parameters

  • Allows users to more easily define parameters that are used in multiple workflows of the same project
    • E.g., hundreds of workflows that use the same time parameter ${dt}
    • E.g., hundreds of workflows that use the same result location parameter ${loc}

UI

截屏2023-05-23 10 46 25

Restful API

1st iteration

  • createProjectParameter 截屏2023-05-26 12 02 22

  • updateProjectParameter 截屏2023-05-26 12 02 03

  • deleteProjectParametersByCode 截屏2023-05-26 12 02 31

  • batchDeleteProjectParametersByCodes 截屏2023-05-26 12 02 40

  • queryProjectParameterListPaging 截屏2023-05-26 12 02 13

  • queryProjectParameterByCode 截屏2023-05-26 11 59 07

2nd iteration

  • batchExportByNames
  • import

Sub-task

  • #14214
  • #14218
  • #14339

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

rickchengx avatar May 10 '23 07:05 rickchengx

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

github-actions[bot] avatar May 10 '23 07:05 github-actions[bot]

thanks for your proposal, I add label discussion because I am not sure whether we need a project level parameter, or do we need a system level one, can you share your design before coding? @rickchengx

zhongjiajie avatar May 18 '23 02:05 zhongjiajie

thanks for your proposal, I add label discussion because I am not sure whether we need a project level parameter, or do we need a system level one, can you share your design before coding? @rickchengx

Of course, I'll add some design later.

rickchengx avatar May 18 '23 05:05 rickchengx

@rickchengx Sounds great. I have the same idea with you. Would you like to talk about this feature?

calvinjiang avatar May 22 '23 10:05 calvinjiang

Hi, @calvinjiang , I've added some design in this issue and I'll talk about this in our weekly-meeting at 8pm on May 24th. Are u interested in the front-end part of this feature?

rickchengx avatar May 23 '23 02:05 rickchengx

I'll try to support some of front-end works. But I'm not sure if I have time to attend the weekly-meeting.

calvinjiang avatar May 24 '23 03:05 calvinjiang

I'll try to support some of front-end works. But I'm not sure if I have time to attend the weekly-meeting.

Hi, @calvinjiang I added some description about the restful interface and split the front-end tasks. If you are interested in this, please comment under this issue

  • #14218

rickchengx avatar May 26 '23 04:05 rickchengx

I'll try to support some of front-end works. But I'm not sure if I have time to attend the weekly-meeting.

Hi, @calvinjiang I added some description about the restful interface and split the front-end tasks. If you are interested in this, please comment under this issue

@rickchengx I already leave a comment under that issue.

calvinjiang avatar May 26 '23 11:05 calvinjiang

Hi @rickchengx , How's it going with the backend api? I need some more details about the backend apis. If you're all set, you could push your feature first.

calvinjiang avatar Jun 02 '23 05:06 calvinjiang

Hi @rickchengx , How's it going with the backend api? I need some more details about the backend apis. If you're all set, you could push your feature first.

Hi, @calvinjiang , I've added the controller in #14264 for your reference

rickchengx avatar Jun 02 '23 05:06 rickchengx

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Aug 14 '24 00:08 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Oct 09 '24 00:10 github-actions[bot]