dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement-#11863][task-plugin] add the function of stopping SQL type tasks

Open fengjian1129 opened this issue 3 years ago • 6 comments

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

fengjian1129 avatar Sep 09 '22 02:09 fengjian1129

@ruanwenjun hi bro,review the code,Thanks

fengjian1129 avatar Sep 09 '22 02:09 fengjian1129

Codecov Report

Merging #11871 (e2b4670) into dev (e20f17a) will increase coverage by 0.05%. The diff coverage is 36.71%.

@@             Coverage Diff              @@
##                dev   #11871      +/-   ##
============================================
+ Coverage     38.53%   38.59%   +0.05%     
- Complexity     4036     4047      +11     
============================================
  Files           994     1000       +6     
  Lines         36725    36751      +26     
  Branches       4275     4277       +2     
============================================
+ Hits          14153    14185      +32     
- Misses        20945    20946       +1     
+ Partials       1627     1620       -7     
Impacted Files Coverage Δ
...olphinscheduler/api/controller/BaseController.java 53.52% <ø> (ø)
.../apache/dolphinscheduler/api/dto/TaskCountDto.java 94.44% <ø> (ø)
...heduler/api/dto/queue/QueueListPagingResponse.java 0.00% <0.00%> (ø)
...nscheduler/api/security/impl/ldap/LdapService.java 6.38% <ø> (ø)
...nscheduler/api/service/impl/LoggerServiceImpl.java 69.49% <ø> (+0.26%) :arrow_up:
...scheduler/api/service/impl/ProjectServiceImpl.java 59.64% <0.00%> (-1.89%) :arrow_down:
...inscheduler/server/log/LoggerRequestProcessor.java 17.14% <0.00%> (ø)
...ver/master/event/TaskTimeoutStateEventHandler.java 0.00% <0.00%> (ø)
...er/master/processor/TaskExecuteStartProcessor.java 0.00% <0.00%> (ø)
...eduler/server/master/task/MasterHeartBeatTask.java 4.00% <0.00%> (-0.35%) :arrow_down:
... and 61 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 09 '22 04:09 codecov-commenter

@caishunfeng hi bro,review the code,Thanks

fengjian1129 avatar Sep 14 '22 08:09 fengjian1129

@ruanwenjun @caishunfeng I have modified the code and many tools classes have been merged, and the local test has been completed

fengjian1129 avatar Sep 15 '22 08:09 fengjian1129

@caishunfeng UT failed.... I haven't modified this method(org.apache.dolphinscheduler.server.utils. ProcessUtilsTest .getPidsStr())

fengjian1129 avatar Sep 16 '22 10:09 fengjian1129

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions[bot] avatar Jan 31 '24 00:01 github-actions[bot]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]