dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[fix-#11753] send alert error alert data id

Open fuchanghai opened this issue 3 years ago • 7 comments

Purpose of the pull request

send alert error alert data id

Brief change log

ATT

Verify this pull request

This pull request is code cleanup without any test coverage.

this close #11753

fuchanghai avatar Sep 05 '22 05:09 fuchanghai

Codecov Report

Merging #11774 (4743381) into dev (d526dd8) will decrease coverage by 0.02%. The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev   #11774      +/-   ##
============================================
- Coverage     39.40%   39.38%   -0.03%     
+ Complexity     4128     4124       -4     
============================================
  Files          1010     1010              
  Lines         37817    37816       -1     
  Branches       4345     4346       +1     
============================================
- Hits          14903    14895       -8     
- Misses        21188    21192       +4     
- Partials       1726     1729       +3     
Impacted Files Coverage Δ
...inscheduler/api/controller/ExecutorController.java 21.12% <ø> (-1.10%) :arrow_down:
...che/dolphinscheduler/api/python/PythonGateway.java 17.14% <ø> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 43.73% <ø> (ø)
...dolphinscheduler/dao/entity/ProcessDefinition.java 23.07% <ø> (ø)
.../server/master/runner/WorkflowExecuteRunnable.java 7.92% <0.00%> (+<0.01%) :arrow_up:
...inscheduler/service/alert/ProcessAlertManager.java 42.08% <ø> (-0.40%) :arrow_down:
...java/org/apache/dolphinscheduler/dao/AlertDao.java 29.32% <57.14%> (+0.97%) :arrow_up:
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) :arrow_down:
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-2.86%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 06 '22 03:09 codecov-commenter

Please associate issue.

done

fuchanghai avatar Sep 06 '22 05:09 fuchanghai

@SbloodyS @caishunfeng @Amy0104 if the value of warningGroupId is null. which effect to front end,or backend?

fuchanghai avatar Sep 06 '22 13:09 fuchanghai

use-modal.ts looks like need to modify.

stalary avatar Sep 15 '22 02:09 stalary

use-modal.ts

use-modal.ts looks like need to modify.

the value of warningGroupId that come from front end is null

fuchanghai avatar Sep 15 '22 02:09 fuchanghai

@caishunfeng @stalary @SbloodyS @ruanwenjun PTAL

fuchanghai avatar Sep 16 '22 06:09 fuchanghai