dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Feature-7024] Add waiting strategy to support master/worker can recover from registry lost

Open ruanwenjun opened this issue 3 years ago • 2 comments

Purpose of the pull request

Close #7024

Brief change log

  • Add ConnectStrategy used for registry connection disconnect/reconnect
  • Add stop/waiting strategy
  • Use ServerLifyCycleManager to replace Stopper

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

ruanwenjun avatar Aug 09 '22 07:08 ruanwenjun

Codecov Report

Merging #11368 (7bb2337) into dev (496c2d4) will decrease coverage by 0.21%. The diff coverage is 22.69%.

:exclamation: Current head 7bb2337 differs from pull request most recent head cf93ac0. Consider uploading reports for the commit cf93ac0 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11368      +/-   ##
============================================
- Coverage     39.43%   39.22%   -0.22%     
  Complexity     4622     4622              
============================================
  Files           980      987       +7     
  Lines         37260    37543     +283     
  Branches       4176     4178       +2     
============================================
+ Hits          14695    14727      +32     
- Misses        21031    21279     +248     
- Partials       1534     1537       +3     
Impacted Files Coverage Δ
...che/dolphinscheduler/alert/AlertSenderService.java 49.64% <0.00%> (ø)
...org/apache/dolphinscheduler/alert/AlertServer.java 51.28% <0.00%> (ø)
...ler/common/lifecycle/ServerLifeCycleException.java 0.00% <0.00%> (ø)
...duler/common/lifecycle/ServerLifeCycleManager.java 0.00% <0.00%> (ø)
...olphinscheduler/common/lifecycle/ServerStatus.java 0.00% <0.00%> (ø)
...e/dolphinscheduler/server/master/MasterServer.java 0.00% <0.00%> (ø)
...inscheduler/server/master/config/MasterConfig.java 0.00% <0.00%> (ø)
...ver/master/consumer/TaskPriorityQueueConsumer.java 0.00% <0.00%> (ø)
...master/dispatch/executor/NettyExecutorManager.java 0.00% <ø> (ø)
...eduler/server/master/event/WorkflowEventQueue.java 0.00% <0.00%> (ø)
... and 30 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 10 '22 04:08 codecov-commenter

@zhongjiajie This PR has some changes about the doc, please take a look.

ruanwenjun avatar Aug 12 '22 07:08 ruanwenjun