[Feature-11298] [API] Refactor org.apache.dolphinscheduler.api.service.AlertPluginInstanceService
Purpose of the pull request
see #11298
Codecov Report
Merging #11354 (8e5606b) into dev (0fdec2c) will decrease coverage by
0.02%. The diff coverage is69.23%.
@@ Coverage Diff @@
## dev #11354 +/- ##
============================================
- Coverage 40.28% 40.25% -0.03%
+ Complexity 4846 4842 -4
============================================
Files 974 974
Lines 37323 37322 -1
Branches 4141 4142 +1
============================================
- Hits 15036 15025 -11
- Misses 20739 20750 +11
+ Partials 1548 1547 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...i/service/impl/AlertPluginInstanceServiceImpl.java | 60.74% <61.90%> (+0.55%) |
:arrow_up: |
| .../api/controller/AlertPluginInstanceController.java | 100.00% <100.00%> (ø) |
|
| ...r/plugin/registry/zookeeper/ZookeeperRegistry.java | 48.64% <0.00%> (-7.21%) |
:arrow_down: |
| ...er/master/dispatch/host/assign/RandomSelector.java | 77.77% <0.00%> (-5.56%) |
:arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Hi @MichaelDeSteven , please split the service part and the v2 controller/entity part into two PR based on the conclusions in https://github.com/apache/dolphinscheduler/pull/10998#issuecomment-1207708303.
Hi @MichaelDeSteven , please split the service part and the v2 controller/entity part into two PR based on the conclusions in #10998 (comment).
Got it.
PTAL @SbloodyS @caishunfeng
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.








