dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Fix-11237][api&datasource-plugin]fix Presto data source bug

Open hyjunhyj opened this issue 3 years ago • 10 comments

Purpose of the pull request

this closes #11237

Brief change log

  • support catalog/database(schema) format when creating presto data source
  • fix the problem that when using the presto data source on the data quality page, the column of the same name table in other databases would be scanned

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.

hyjunhyj avatar Aug 02 '22 10:08 hyjunhyj

@hyjunhyj May I ask whether there are any follow-ups to this PR? Thanks : )

EricGao888 avatar Oct 25 '22 07:10 EricGao888

@hyjunhyj May I ask whether there are any follow-ups to this PR? Thanks : )

The ui needs to be modified. @zlxl666 will help me.

hyjunhyj avatar Oct 26 '22 06:10 hyjunhyj

@zllxl will help me modify the ui, please add him to the assignees. Thanks. @EricGao888

hyjunhyj avatar Oct 27 '22 09:10 hyjunhyj

hi @hyjunhyj , so sorry for this PR hasn't been merged for months, can you solve the conflicts? image

By the way, please feel free to contact me (mail: [email protected] or wechat: taskflow), I think I can help you to finish the first contribution

davidzollo avatar Dec 12 '22 13:12 davidzollo

I have resolved the conflict. Can you check it for me? Thank you. @davidzollo

hyjunhyj avatar Dec 27 '22 11:12 hyjunhyj

Hi @hyjunhyj I approval to start the CI

zhongjiajie avatar Dec 28 '22 07:12 zhongjiajie

Codecov Report

Merging #11260 (fa0bb70) into dev (de70421) will decrease coverage by 0.01%. The diff coverage is 34.61%.

@@             Coverage Diff              @@
##                dev   #11260      +/-   ##
============================================
- Coverage     39.55%   39.53%   -0.02%     
- Complexity     4292     4293       +1     
============================================
  Files          1072     1072              
  Lines         40541    40565      +24     
  Branches       4662     4665       +3     
============================================
+ Hits          16034    16036       +2     
- Misses        22724    22748      +24     
+ Partials       1783     1781       -2     
Impacted Files Coverage Δ
...eduler/api/service/impl/DataSourceServiceImpl.java 49.85% <0.00%> (-0.91%) :arrow_down:
...source/presto/param/PrestoDataSourceProcessor.java 40.35% <23.07%> (-6.32%) :arrow_down:
...datasource/presto/param/PrestoConnectionParam.java 80.00% <100.00%> (+30.00%) :arrow_up:
...asource/presto/param/PrestoDataSourceParamDTO.java 66.66% <100.00%> (+33.33%) :arrow_up:
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) :arrow_down:
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) :arrow_down:
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Dec 28 '22 07:12 codecov-commenter

image image

Hi @zhongjiajie , sonar reports a bug, I checked and I didn't change that file when fixing this issue. Is there anything else I need to do?

hyjunhyj avatar Dec 29 '22 03:12 hyjunhyj

Close due to inactivity.

SbloodyS avatar Mar 18 '24 02:03 SbloodyS