datafusion
datafusion copied to clipboard
apache
Internal_err! is over used in core code and should be replaced with exec_err! or plan_err! in many places
Describe the bug
internal_err! is used as a general error macro in many spots in the code where in fact the problem the error is propagating is not caused by an oversight, bug, etc in the code but rather by user error. A good example of this can be seen in PR #9137 comment where it's being used to let the user know they provided a datatype as an argument to a function that it doesn't support. This in fact should be an exec_err! in this example.
To Reproduce
No response
Expected behavior
In most cases where the error is caused by incorrect data types or invalid argument counts exec_err! should be used.
Additional context
No response
