datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard
verified publisher icon apache

test: show stats in explain of two representative queries

Open NGA-TRAN opened this issue 2 years ago • 4 comments

Which issue does this PR close?

Tests for https://github.com/apache/arrow-datafusion/issues/8155

Rationale for this change

I have found that statistics were lost being propagated upward in the plan. These are tests that include representative operators for us to verify whether the statistics are computed and propagated up correctly

What changes are included in this PR?

Add 2 explains

Are these changes tested?

They are tests only

Are there any user-facing changes?

No

NGA-TRAN avatar Nov 14 '23 18:11 NGA-TRAN

marking as draft to show this PR isn't waiting for review

alamb avatar Dec 17 '23 12:12 alamb

@alamb : It seems there are improvements in statistics recently. Do you think we still need this kind of tests?

NGA-TRAN avatar Mar 21 '24 19:03 NGA-TRAN

I think the tests in this PR add value as they function as an end to end test of statistics calculation and propagation -- perhaps we can move them to a different .slt file (statistics.slt perhaps)?

alamb avatar Mar 22 '24 14:03 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 22 '24 01:05 github-actions[bot]