datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

[feat] Support columns_sorted in row_filters with pageIndex

Open judahrand opened this issue 2 years ago • 3 comments

Which issue does this PR close?

Closes #3476

I've picked up here where @Ted-Jiang left off in #3477. I think that I've dealt with some of the comments.

However, I'm not sure if we also need to check that the maximum value is each row group is greater than or equal to the value in the previous row group? This would involve accessing the row group level statistics.

I'd really appreciate thoughts and advice here as I'm keen to learn more about Datafusion and hopefully be able to contribute more in the future!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

judahrand avatar Sep 12 '23 09:09 judahrand

Thanks @judahrand -- I will give this a look

alamb avatar Sep 12 '23 20:09 alamb

Marking as draft as this PR has some feedback that is awaiting addressing

alamb avatar Sep 18 '23 15:09 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 30 '24 01:04 github-actions[bot]