datafusion
datafusion copied to clipboard
Use more _dyn kernels instead of macros in binary.rs (WIP)
(Draft until I complete checklist below)
Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/1474
Rationale for this change
This is part of my long term attempt to remove the macro nest in binary.rs
The rationale is
- Make it easier to understand what is going on in binary.rs -- everytime I try to make a change in there it takes several minutes of study to get a handle on things.
- Help define easier to use APIs in arrow-r, and fill out the feature gaps
What changes are included in this PR?
- [x] Remove
binary_primitive_array_op!macro :tada:, replaceadd_dyn,subtract_dyn,multiply_dynanddivide_dyn - [ ] Remove
binary_primitive_array_op_scalarmcacro, replace withadd_dyn_scalar,subtract_dyn_scalar,multiply_dyn_scalaranddivide_dyn_scalar - [ ] Add wrapper
- [ ] File follow on tickets in arrow-rs
Are there any user-facing changes?
No
I keep getting stymied by binary.rs -- https://github.com/apache/arrow-datafusion/pull/3026 hopefully will help
Will pick this back up eventually -- but has bitrotted so closing for now