datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Use more _dyn kernels instead of macros in binary.rs (WIP)

Open alamb opened this issue 3 years ago • 1 comments

(Draft until I complete checklist below)

Which issue does this PR close?

re https://github.com/apache/arrow-datafusion/issues/1474

Rationale for this change

This is part of my long term attempt to remove the macro nest in binary.rs

The rationale is

  1. Make it easier to understand what is going on in binary.rs -- everytime I try to make a change in there it takes several minutes of study to get a handle on things.
  2. Help define easier to use APIs in arrow-r, and fill out the feature gaps

What changes are included in this PR?

  • [x] Remove binary_primitive_array_op! macro :tada:, replace add_dyn, subtract_dyn, multiply_dyn and divide_dyn
  • [ ] Remove binary_primitive_array_op_scalar mcacro, replace with add_dyn_scalar, subtract_dyn_scalar, multiply_dyn_scalar and divide_dyn_scalar
  • [ ] Add wrapper
  • [ ] File follow on tickets in arrow-rs

Are there any user-facing changes?

No

alamb avatar Aug 01 '22 18:08 alamb

I keep getting stymied by binary.rs -- https://github.com/apache/arrow-datafusion/pull/3026 hopefully will help

alamb avatar Aug 03 '22 11:08 alamb

Will pick this back up eventually -- but has bitrotted so closing for now

alamb avatar Sep 20 '22 14:09 alamb