datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Add SQL query planner support for time literal

Open andygrove opened this issue 3 years ago • 2 comments

Which issue does this PR close?

Part of https://github.com/apache/arrow-datafusion/issues/2883

Rationale for this change

Support more SQL in the SQL query planner

What changes are included in this PR?

Add support for TIME literal values in SQL query planner

Are there any user-facing changes?

No

andygrove avatar Jul 12 '22 16:07 andygrove

Converting to draft as this isn't enough.

SELECT TIME '08:08:00.091' AS "T";
Internal("Unsupported CAST from Utf8 to Time32(Millisecond)")

andygrove avatar Jul 12 '22 16:07 andygrove

Codecov Report

Merging #2884 (3b9c2a2) into master (d25e822) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
+ Coverage   85.25%   85.35%   +0.09%     
==========================================
  Files         275      276       +1     
  Lines       49010    49295     +285     
==========================================
+ Hits        41785    42075     +290     
+ Misses       7225     7220       -5     
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 81.42% <100.00%> (+0.04%) :arrow_up:
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) :arrow_down:
datafusion/common/src/scalar.rs 75.77% <0.00%> (-0.12%) :arrow_down:
datafusion/core/tests/sql/timestamp.rs 100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/mod.rs 100.00% <0.00%> (ø)
datafusion/physical-expr/src/expressions/delta.rs 100.00% <0.00%> (ø)
datafusion/optimizer/src/simplify_expressions.rs 82.00% <0.00%> (+0.02%) :arrow_up:
...tafusion/physical-expr/src/expressions/datetime.rs 86.80% <0.00%> (+54.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d25e822...3b9c2a2. Read the comment docs.

codecov-commenter avatar Jul 12 '22 17:07 codecov-commenter

Possibly related / redundant with @stuartcarnie 's https://github.com/apache/arrow-datafusion/pull/3010

alamb avatar Aug 13 '22 10:08 alamb

Closing this in favor of https://github.com/apache/arrow-datafusion/pull/3010

andygrove avatar Aug 15 '22 18:08 andygrove