datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

POC: Remove unnecessary null check for `GroupColumn`

Open Rachelint opened this issue 1 year ago • 1 comments

Which issue does this PR close?

Closes #. POC for checking #12944 , not for merged

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Rachelint avatar Oct 15 '24 19:10 Rachelint

I found it actually now a trivial change. The challenge is that, we should refactor codes to support vectorize append firstly (otherwise, we need to add a branch for row's appending, and as a reuslt, we remove a row level branch and add another...)

I am trying it.

Rachelint avatar Oct 16 '24 16:10 Rachelint

It is poc version of #12996

Rachelint avatar Nov 25 '24 05:11 Rachelint