Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485
Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485
Which issue does this PR close?
Closes #10485 .
Are these changes tested?
Covered by existing tests
Thanks @iiiancampbell ! I triggered the CI to start
Oops , my bad, accidentally used 2 ","s to end the statement, I made my original commit late at night 😅 . My latest commit should pass all validation now
Hm, apologies @yyy1000 , taking a look at some tests that could help here, wasn't sure which one was applicable though.
Tried cargo test -p datafusion parquet_exec which doesnt let builder.rs compile due to various lines expecting either 'LogicalPlan' or 'Arc<LogicalPlan>' or vice versa.
Could you point me in the correct direction by any chance?
Could you point me in the correct direction by any chance?
I think you will need to check out the code and make the relevant changes to get the code to compile
Converting to draft as we work to fix CI
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.