datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485

Open iiiancampbell opened this issue 1 year ago • 5 comments

Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> #10485

Which issue does this PR close?

Closes #10485 .

Are these changes tested?

Covered by existing tests

iiiancampbell avatar May 13 '24 14:05 iiiancampbell

Thanks @iiiancampbell ! I triggered the CI to start

alamb avatar May 13 '24 15:05 alamb

Oops , my bad, accidentally used 2 ","s to end the statement, I made my original commit late at night 😅 . My latest commit should pass all validation now

iiiancampbell avatar May 14 '24 03:05 iiiancampbell

Hm, apologies @yyy1000 , taking a look at some tests that could help here, wasn't sure which one was applicable though. Tried cargo test -p datafusion parquet_exec which doesnt let builder.rs compile due to various lines expecting either 'LogicalPlan' or 'Arc<LogicalPlan>' or vice versa.

Could you point me in the correct direction by any chance?

iiiancampbell avatar May 14 '24 09:05 iiiancampbell

Could you point me in the correct direction by any chance?

I think you will need to check out the code and make the relevant changes to get the code to compile

alamb avatar May 14 '24 19:05 alamb

Converting to draft as we work to fix CI

alamb avatar May 15 '24 19:05 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 15 '24 01:07 github-actions[bot]