datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Document Sort Merge Join algorithm

Open comphead opened this issue 1 year ago • 4 comments

Is your feature request related to a problem or challenge?

I faced that it is challenging to understand fully how Sort Merge Join sort_merge_join.rs implemented and would be nice to get it documented the same way as HashJoin in hash_join.rs

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

comphead avatar May 02 '24 20:05 comphead

Found when fixing SMJ bugs https://github.com/apache/datafusion/pull/10304

comphead avatar May 02 '24 20:05 comphead

cc @korowa you might be interested

comphead avatar May 02 '24 20:05 comphead

Maybe @metesynnada can help remember who knows about this code too

alamb avatar May 02 '24 20:05 alamb

I spent some time reading and understanding the code last time I worked with it. I may try to document it some once I get time to refresh it...

viirya avatar May 02 '24 21:05 viirya