feat: Add HashJoin support for BuildRight
Which issue does this PR close?
Closes #390.
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Codecov Report
Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 34.30%. Comparing base (
fcf7d5b) to head (f1d5aeb). Report is 8 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| .../scala/org/apache/comet/serde/QueryPlanSerde.scala | 0.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #437 +/- ##
============================================
+ Coverage 34.17% 34.30% +0.13%
- Complexity 850 855 +5
============================================
Files 116 116
Lines 38547 38653 +106
Branches 8523 8545 +22
============================================
+ Hits 13172 13259 +87
- Misses 22609 22647 +38
+ Partials 2766 2747 -19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This requires https://github.com/apache/datafusion/pull/10702 to be in DataFusion new release.
Hmm, it's weird. I've updated the plan stability results. However, CometTPCDSV2_7_PlanStabilitySuite still fails on q5a for Spark 4.0 only in CI. And I cannot reproduce it locally. So my local generated q5a query plans are different to CI?
Hmm, it's weird. I've updated the plan stability results. However,
CometTPCDSV2_7_PlanStabilitySuitestill fails on q5a for Spark 4.0 only in CI. And I cannot reproduce it locally. So my local generated q5a query plans are different to CI?
I finally produced the query plan same as CI by following same commands of the CI pipeline.
Merged. Thanks @kazuyukitanimura @andygrove