datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard

feat: Add HashJoin support for BuildRight

Open viirya opened this issue 1 year ago • 1 comments

Which issue does this PR close?

Closes #390.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

viirya avatar May 16 '24 06:05 viirya

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 34.30%. Comparing base (fcf7d5b) to head (f1d5aeb). Report is 8 commits behind head on main.

Files Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #437      +/-   ##
============================================
+ Coverage     34.17%   34.30%   +0.13%     
- Complexity      850      855       +5     
============================================
  Files           116      116              
  Lines         38547    38653     +106     
  Branches       8523     8545      +22     
============================================
+ Hits          13172    13259      +87     
- Misses        22609    22647      +38     
+ Partials       2766     2747      -19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 18 '24 18:05 codecov-commenter

This requires https://github.com/apache/datafusion/pull/10702 to be in DataFusion new release.

viirya avatar May 28 '24 20:05 viirya

Hmm, it's weird. I've updated the plan stability results. However, CometTPCDSV2_7_PlanStabilitySuite still fails on q5a for Spark 4.0 only in CI. And I cannot reproduce it locally. So my local generated q5a query plans are different to CI?

viirya avatar Jun 08 '24 00:06 viirya

Hmm, it's weird. I've updated the plan stability results. However, CometTPCDSV2_7_PlanStabilitySuite still fails on q5a for Spark 4.0 only in CI. And I cannot reproduce it locally. So my local generated q5a query plans are different to CI?

I finally produced the query plan same as CI by following same commands of the CI pipeline.

viirya avatar Jun 08 '24 05:06 viirya

Merged. Thanks @kazuyukitanimura @andygrove

viirya avatar Jun 08 '24 07:06 viirya